Skip to content

fix: one more deferred close adjustment #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
egibs merged 1 commit into from
Feb 6, 2026
Merged

fix: one more deferred close adjustment #1361

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pkg/action/diff.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,14 +251,13 @@ func Diff(ctx context.Context, c malcontent.Config, _ *clog.Logger) (*malcontent
if err != nil {
return nil, err
}
defer srcFile.Close()

st, err := srcFile.Stat()
if err != nil {
return nil, err
}

defer srcFile.Close()

// create a buffer sized to the minimum of the file's size or the default ReadBuffer
// only do so if we actually need to retrieve the file's contents
buf := readPool.Get(min(st.Size(), file.ReadBuffer)) //nolint:nilaway // the buffer pool is created above
Expand Down