Skip to content

fix: avoid deadlock in TestStringPoolRaceCondition #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
egibs merged 2 commits into from
Feb 23, 2026
Merged

fix: avoid deadlock in TestStringPoolRaceCondition #1395

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7349ad
fix: avoid deadlock in TestStringPoolRaceCondition
egibs Feb 23, 2026
0514669
Merge branch 'main' into fix-test-deadlock
egibs Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions pkg/report/strings_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,12 +223,10 @@ func TestStringPoolRaceCondition(t *testing.T) {
pool := NewStringPool()

var wg sync.WaitGroup
wg.Add(numGoroutines * 3)

// Concurrent interning of identical strings
for range numGoroutines {
wg.Go(func() {
defer wg.Done()
for range numOps {
pool.Intern("shared")
}
Expand All @@ -238,17 +236,16 @@ func TestStringPoolRaceCondition(t *testing.T) {
// Concurrent interning of unique strings
for i := range numGoroutines {
wg.Go(func() {
defer wg.Done()
for j := range numOps {
pool.Intern(fmt.Sprintf("unique-%d-%d", i, j))
}
})
}

// Concurrent clear operations
for range numGoroutines {
// Use a small number of goroutines to exercise the race detector without triggering
// resize contention in xsync.Map.
for range 10 {
wg.Go(func() {
defer wg.Done()
for range numOps {
pool.clear()
}
Expand Down