Detect npm credential exfil in install scripts#1501
Merged
Conversation
Big-Comfy
force-pushed
the
npm-credential-exfil-rule
branch
from
7a54f42 to
e695690
Compare
Signed-off-by: Nikhil <tad.areas_0y@icloud.com>
Signed-off-by: Nikhil <tad.areas_0y@icloud.com>
Big-Comfy
force-pushed
the
npm-credential-exfil-rule
branch
from
1ff6cf2 to
149bbbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a high-risk npm rule for install-time scripts that touch package-manager credentials and also send data over HTTP.
I added a small fixture/test with a
postinstallscript that reads.npmrc/ token env vars and posts them, plus a release-script fixture that mentionsNPM_TOKENbut should stay quiet.The rule metadata also links Unit 42's Shai-Hulud writeup, since that attack used npm install hooks to harvest and exfiltrate developer credentials.
I also opened chainguard-sandbox/malcontent-samples#52 so this can be covered by the sample-output tests once that sample lands.
Checked:
make yara-x-compile