fix: Reduce Malcontent JS False Positives#904
Merged
Conversation
fix(js): Reducing severity of javascript issues to reduce false positive blockers
eslerm
approved these changes
May 7, 2025
Contributor
eslerm
left a comment
eslerm
left a comment
There was a problem hiding this comment.
Thank you for jumping on this!
…a6.js.simple Signed-off-by: antitree <antitree@users.noreply.github.com>
antitree
added a commit
to antitree/malcontent
that referenced
this pull request
May 8, 2025
fix: Reduce Malcontent JS False Positives (chainguard-dev#904)
antitree
added a commit
to antitree/malcontent
that referenced
this pull request
May 8, 2025
antitree
added a commit
to antitree/malcontent
that referenced
this pull request
May 8, 2025
Revert "fix: Reduce Malcontent JS False Positives (chainguard-dev#904)"
antitree
added a commit
to antitree/malcontent
that referenced
this pull request
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix adjusts the severity on some of the obfuscation rules and one of the rules for javascript reversing that was producing a high number of false positives. I think we can roll this change back after we've tuned these rules to producer higher quality results.