Support absolute include paths when calling malcontent externally#944
Merged
Conversation
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
egibs
force-pushed
the
external-library-includes
branch
from
4f2c1ca to
6ed3d9e
Compare
egibs
changed the title
include paths when calling malcontent externally
tstromberg
approved these changes
May 22, 2025
eslerm
reviewed
May 22, 2025
Contributor
eslerm
left a comment
eslerm
left a comment
There was a problem hiding this comment.
Thanks for clarifying variables names while adding this check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes from #937 to replace the relative include path with its absolute path worked in the context of this repository's directory structure but not when installed as a module and used elsewhere (e.g., importing malcontent as a library).
This PR should allow us to locate
rules/regardless of where we call malcontent from. I've validated this where I saw the failure and it works with these changes.