Avoid failing scans outright when encountering extraction failures#962
Merged
Merged
Conversation
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
044e9f6 to
b6cda75
Compare
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
eslerm
approved these changes
May 27, 2025
Contributor
eslerm
left a comment
There was a problem hiding this comment.
Appreciate that a minified test is included 🙏
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently fail scans when encountering extraction errors which will prevent any report generation. This is not great when scanning many files wherein only one or a handful of files cannot be processed.
This PR introduces an opt-out flag (
--exit-extraction) to ignore these failures. By default, the behavior remains the same but it's easy enough to default this tofalsein the future. I added two new test cases to cover the new configuration option and it behaves as expected.I also addressed an inconsistency between
mimetype.DetectandPath. The latter would not return a valid MIME type which would cause issues if we were expectingft.MIMEto be populated. We also need to keep a list of valid archive extensions and at least one MIME type in thesupportedKindmap. In cases like.zipor.gzextractions, we can do another lookup to cover additional types in cases wheremimetype.Detectis used overPath.FWIW, we do mitigate this in other places by doing something like: