Address extraction edge cases re: duplicate file names#967
Merged
Conversation
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
eslerm
approved these changes
May 29, 2025
Contributor
eslerm
left a comment
There was a problem hiding this comment.
appreciate simplifications :)
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More fallout from scanning Sonarqube.
There are five files of interest in this package:
Our original extraction logic would only process one of the extracted
nodefiles because only the file name (node) was stored in the extracted file map. Additionally, extracting the files would fail with legitimate EOF errors and this was also happening with thesonarjs-1.0.0.tgzfile. There was also an opportunity to clean up the awkwardextractedFilesmap ranging and replace it withfilepath.WalkDir.This PR addresses this edge case, decompresses files in such a way to preserve their parent directory, and removes archive types from
supportedKindwhich causes weird behavior. Instead, we can return a non-nilFileTypeif a given path's extension is present in the archive map.The test files being erased is expected; these files are actually
tarfiles for some reason (?) and removingtarfromsupportedKindmeans they aren't scanned directly.