2025/06/02 false positive reduction#976
Merged
Merged
Conversation
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
antitree
suggested changes
Jun 2, 2025
Contributor
antitree
left a comment
antitree
left a comment
There was a problem hiding this comment.
I think we can approve this in the short term but I'm interested in your response to the comments. If the goala are 1) protect the product 2) do not block a team on a false positive we're doing a good job at 1 but what's our assessment of 2?
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
eslerm
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses most of the outstanding false positives we've seen recently. The plan is to merge this and run another audit. Any outstanding findings can be picked up in a subsequent PR.