Skip to content

Hide noisy error logs; final rule tweaks #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
egibs merged 3 commits into from
Jun 2, 2025
Merged

Hide noisy error logs; final rule tweaks #977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e942313
Hide noisy error logs; final rule tweaks
egibs Jun 2, 2025
d03def6
Run make yara-x-fmt
egibs Jun 2, 2025
f587b9e
Final tweak
egibs Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/action/path.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ func findFilesRecursively(ctx context.Context, rootPath string) ([]string, error
err = filepath.WalkDir(root,
func(path string, info os.DirEntry, err error) error {
if err != nil {
logger.Errorf("error: %s: %s", path, err)
logger.Debugf("error: %s: %s", path, err)
return nil
}
if info.IsDir() || strings.Contains(path, "/.git/") {
Expand All @@ -52,12 +52,12 @@ func findFilesRecursively(ctx context.Context, rootPath string) ([]string, error
logger.Debugf("attempting to resolve symlink: %s", path)
eval, err := filepath.EvalSymlinks(path)
if err != nil {
logger.Errorf("eval: %s: %s", path, err)
logger.Debugf("eval: %s: %s", path, err)
return nil
}
fi, err := os.Stat(eval)
if err != nil {
logger.Errorf("stat: %s: %s", path, err)
logger.Debugf("stat: %s: %s", path, err)
return nil
}
if fi.IsDir() {
Expand Down
15 changes: 15 additions & 0 deletions rules/false_positives/nextcloud.yara
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
rule vimeo_psalm_md_php_override: override {
meta:
description = "Psalm MD files with PHP code excerpts"
SIGNATURE_BASE_WEBSHELL_PHP_Dynamic = "harmless"

strings:
$ = "Emitted when calling a function on a non-callable variable"
$ = "Emitted when calling a function on a value whose type Psalm cannot infer."
$ = "Emitted when trying to use `null` as a `callable`"
$ = "Emitted when trying to call a function on a value that may not be callable"
$ = "Emitted when trying to call a function on a value that may be null"

condition:
any of them
}
10 changes: 5 additions & 5 deletions rules/false_positives/sqlmap.yara
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ rule sqlmap_override: override {
SIGNATURE_BASE_Hacktool_Strings_P0Wnedshell = "high"

strings:
$sqlmap1 = "Copyright (c) 2006-2025 sqlmap developers (https://sqlmap.org/)"
$sqlmap2 = "Visit 'https://github.com/sqlmapproject/sqlmap/#installation' for further details"
$sqlmap3 = /SqlmapBaseException|SqlmapDataException|SqlmapFilePathException|SqlmapShellQuitException|SqlmapSilentQuitException|SqlmapUserQuitException/
$sqlmap4 = "if \"sqlmap.sqlmap\" in sys.modules"
$c_sqlmap1 = "Copyright (c) 2006-2025 sqlmap developers (https://sqlmap.org/)"
$c_sqlmap2 = "Visit 'https://github.com/sqlmapproject/sqlmap/#installation' for further details"
$f_sqlmap3 = /SqlmapBaseException|SqlmapDataException|SqlmapFilePathException|SqlmapShellQuitException|SqlmapSilentQuitException|SqlmapUserQuitException/
$f_sqlmap4 = "if \"sqlmap.sqlmap\" in sys.modules"

condition:
all of them
any of ($c*) and any of ($f*)
}
Loading