Skip to content

Commit 1b9100b

Browse files
authored
check for string true rather than existence in setup-python-keyring (#41)
We saw builds breaking because `python -m pip install "keyrings-chainguard-libraries"` was executing on custom runners which don't have the `python` executable installed. The intent seems to be that this step only runs when `setup-python-keyring` is overriden to `true`, and not by default, but the current implementation will always run it (the `if` statement as currently written evaluates to `true` because the variable exists). This fixes the `if` statement to only evaluate to `true` if `setup-python-keyring` has been overridden to `true`.
1 parent f2fe096 commit 1b9100b

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

action.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ runs:
200200
echo HTTP_AUTH="basic:${{ inputs.apk-host }}:user:$(chainctl auth token --audience ${{ inputs.apk-host }})" >> $GITHUB_ENV
201201
fi
202202
203-
- if: ${{ inputs.setup-python-keyring }}
203+
- if: ${{ inputs.setup-python-keyring == 'true' }}
204204
name: Install Python keyring package
205205
shell: bash
206206
run: |

0 commit comments

Comments
 (0)