scanner-audit/main.go: include GHSA IDs when loading expected vulnerabilities#137
Open
Dev-X25874 wants to merge 1 commit into
Open
scanner-audit/main.go: include GHSA IDs when loading expected vulnerabilities#137Dev-X25874 wants to merge 1 commit into
Dev-X25874 wants to merge 1 commit into
Conversation
…bilities Signed-off-by: Dev-X25874 <283057883+Dev-X25874@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
loadExpectedCVEsfunction filtered expected vulnerability IDs withstrings.HasPrefix(vuln[0], "CVE-"), silently dropping all GHSA-* entriesfrom the expected set.
The answers data contains GHSA identifiers across multiple test cases
(e.g.
fixed-language-package-vulnerabilities,false-positive-language-package-vulnerabilities). With an empty expectedlist,
compareCVEscould never produce false negatives for those test cases,causing them to always appear as passing regardless of actual scanner output.
Remove the prefix guard so all identifiers in the answers file are loaded
as expected vulnerabilities.