Skip to content

feat: allow-environmental-validation-failure input to GA#1584

Draft
algomaster99 wants to merge 7 commits into
mainfrom
claude/optimistic-goodall-Ce0tB
Draft

feat: allow-environmental-validation-failure input to GA#1584
algomaster99 wants to merge 7 commits into
mainfrom
claude/optimistic-goodall-Ce0tB

Conversation

@algomaster99
Copy link
Copy Markdown
Member

@algomaster99 algomaster99 commented May 24, 2026

Fixes #1583

Summary

This PR adds a new optional input allow-environmental-validation-failure to the Maven Lockfile GitHub Action, allowing environmental validation failures (such as Maven version changes between runner image updates) to produce warnings instead of failing the build.

Key Changes

  • action.yml & template/action.yml: Added new input allow-environmental-validation-failure (default: false) with documentation referencing issue Disable environment check in maven-lockfile validation workflow #1583
  • Bash script in action.yml & template/action.yml:
    • Capture the new input as ALLOW_ENV_VALIDATION_FAILURE environment variable
    • Pass it to the Maven plugin via -DallowEnvironmentalValidationFailure=true when enabled
    • Fixed trailing whitespace inconsistencies in the script
  • README.md:
    • Documented the new input with usage guidance and rationale for GitHub-hosted runners
    • Removed leading blank line for consistency

Implementation Details

The new input is passed through to the underlying Maven plugin's allowEnvironmentalValidationFailure configuration parameter. When enabled, environmental validation failures (e.g., Maven version mismatches) will be logged as warnings rather than causing the build to fail, which is particularly useful for workflows using GitHub-hosted runners where the Maven version is not pinned and may change between runner image updates.

https://claude.ai/code/session_01L6ga9Q2tGVvr2uhZ5gtGjV

Comment thread lockfile.json Outdated
"allowValidationFailure": false,
"allowPomValidationFailure": false,
"allowEnvironmentalValidationFailure": false,
"allowEnvironmentalValidationFailure": true,
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"allowEnvironmentalValidationFailure": true,
"allowEnvironmentalValidationFailure": false,

We will change this later when we change the default value to true.

@algomaster99 algomaster99 marked this pull request as draft May 24, 2026 14:56
@algomaster99 algomaster99 force-pushed the claude/optimistic-goodall-Ce0tB branch from f3d2187 to f646f81 Compare May 25, 2026 07:36
@algomaster99 algomaster99 force-pushed the claude/optimistic-goodall-Ce0tB branch from 8622110 to 3ef0955 Compare May 26, 2026 20:58
@algomaster99 algomaster99 changed the title Add allow-environmental-validation-failure input to GitHub Action feat: allow-environmental-validation-failure input to GA May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable environment check in maven-lockfile validation workflow

2 participants