fix: ensure components compile under noUncheckedIndexedAccess#568
Open
tobigumo wants to merge 1 commit into
Open
fix: ensure components compile under noUncheckedIndexedAccess#568tobigumo wants to merge 1 commit into
tobigumo wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
noUncheckedIndexedAccessin the components template tsconfig so downstream CLI consumers with strict tsconfig no longer hit type errors on the shipped templatesfile-uploadFileText in both react and solid: thelength === 1guard did not narrow indexed access; replaced with destructuring + truthy check so neither?.nor!is requiredcheckbox/indeterminateexample by capturing the indexed value locally so the truthy guard narrows for the subsequent spreadfile-uploadregistry output to match the updated sourceTest plan
bun run typecheckpasses incomponents/reactandcomponents/solidfile-uploadregenerated; other registry JSONs left untouched