Tracking: Fix quarterly report - Round down time spent to 6 hours to avoid excess deviation

Author: ywarnier

public/main/inc/ajax/statistics.ajax.php

@@ -1064,6 +1064,9 @@
     case 'report_quarterly_hours_of_training':
         // Close the session as we don't need it any further
         session_write_close();
+        // The maximum time spent, in number of hours, to be considered.
+        // Anything above that is considered a time registration error.
+        $maxTimeSpent = 6;
         $currentQuarterDates = getQuarterDates();
         $pre1QuarterDates = getQuarterDates(
             date_create($currentQuarterDates['quarter_start'])
@@ -1104,27 +1107,33 @@
         // Get data for the row
         $timeSpentCoursesCurrentQuarter = Tracking::getTotalTimeSpentInCourses(
             $currentQuarterDates['quarter_start'],
-            $currentQuarterDates['quarter_end']
+            $currentQuarterDates['quarter_end'],
+            $maxTimeSpent
         );
         $timeSpentCourses1PreQuarter = Tracking::getTotalTimeSpentInCourses(
             $pre1QuarterDates['quarter_start'],
-            $pre1QuarterDates['quarter_end']
+            $pre1QuarterDates['quarter_end'],
+            $maxTimeSpent
         );
         $timeSpentCourses2PreQuarter = Tracking::getTotalTimeSpentInCourses(
             $pre2QuarterDates['quarter_start'],
-            $pre2QuarterDates['quarter_end']
+            $pre2QuarterDates['quarter_end'],
+            $maxTimeSpent
         );
         $timeSpentCourses3PreQuarter = Tracking::getTotalTimeSpentInCourses(
             $pre3QuarterDates['quarter_start'],
-            $pre3QuarterDates['quarter_end']
+            $pre3QuarterDates['quarter_end'],
+            $maxTimeSpent
         );
         $timeSpentCourses4PreQuarter = Tracking::getTotalTimeSpentInCourses(
             $pre4QuarterDates['quarter_start'],
-            $pre4QuarterDates['quarter_end']
+            $pre4QuarterDates['quarter_end'],
+            $maxTimeSpent
         );
         $timeSpentCourses5PreQuarter = Tracking::getTotalTimeSpentInCourses(
             $pre5QuarterDates['quarter_start'],
-            $pre5QuarterDates['quarter_end']
+            $pre5QuarterDates['quarter_end'],
+            $maxTimeSpent
         );
         // Calculate percent for the row
         $percentIncrementTimeSpent = api_calculate_increment_percent(

public/main/inc/lib/tracking.lib.php

@@ -8222,7 +8222,8 @@ public static function getCourseQuizLastFinalizationDate(
      */
     public static function getTotalTimeSpentInCourses(
         string $dateFrom = '',
-        string $dateUntil = ''
+        string $dateUntil = '',
+        ?int $maxTimeSpent = 6
     ): int {
         $tableTrackLogin = Database::get_main_table(TABLE_STATISTIC_TRACK_E_COURSE_ACCESS);
         $tableUrlRelUser = Database::get_main_table(TABLE_MAIN_ACCESS_URL_REL_USER);
@@ -8240,12 +8241,21 @@ public static function getTotalTimeSpentInCourses(
             $dateUntil = Database::escape_string($dateUntil);
             $conditionTime = " (login_course_date >= '$dateFrom' AND logout_course_date <= '$dateUntil' ) ";
         }
-        $sql = "SELECT SUM(TIMESTAMPDIFF(HOUR, login_course_date, logout_course_date)) diff
+        $sql = "SELECT TIMESTAMPDIFF(HOUR, login_course_date, logout_course_date) diff
     	        FROM $tableTrackLogin u $tableUrl
                 WHERE $conditionTime $urlCondition";
         $rs = Database::query($sql);
-        $row = Database::fetch_array($rs, 'ASSOC');
-        $diff = $row['diff'];
+        $diff = 0;
+        if (!empty($rs)) {
+            while ($row = Database::fetch_array($rs)) {
+                // Anything above $maxTimeSpent is rounded down to $maxTimeSpent hours
+                if ($row['diff'] <= $maxTimeSpent) {
+                    $diff += $row['diff'];
+                } else {
+                    $diff += $maxTimeSpent;
+                }
+            }
+        }
         if ($diff >= 0 and !empty($diff)) {
             return $diff;
         }