Skip to content

Internal: Fix course_homepage intro migration for session context #7449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christianbeeznest merged 1 commit into from
Jan 27, 2026
Merged

Internal: Fix course_homepage intro migration for session context #7449

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
126 changes: 92 additions & 34 deletions src/CoreBundle/Migrations/Schema/V200/Version20210930130343.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
namespace Chamilo\CoreBundle\Migrations\Schema\V200;

use Chamilo\CoreBundle\Entity\Course;
use Chamilo\CoreBundle\Entity\Session;
use Chamilo\CoreBundle\Entity\Tool;
use Chamilo\CoreBundle\Migrations\AbstractMigrationChamilo;
use Chamilo\CoreBundle\Repository\Node\CourseRepository;
use Chamilo\CoreBundle\Repository\SessionRepository;
Expand All @@ -24,95 +26,151 @@ public function getDescription(): string

public function up(Schema $schema): void
{
/** @var CToolIntroRepository $introRepo */
$introRepo = $this->container->get(CToolIntroRepository::class);
/** @var CToolRepository $cToolRepo */
$cToolRepo = $this->container->get(CToolRepository::class);
/** @var ToolRepository $toolRepo */
$toolRepo = $this->container->get(ToolRepository::class);
/** @var SessionRepository $sessionRepo */
$sessionRepo = $this->container->get(SessionRepository::class);
/** @var CourseRepository $courseRepo */
$courseRepo = $this->container->get(CourseRepository::class);

/** @var Tool|null $homepageToolEntity */
$homepageToolEntity = $toolRepo->findOneBy(['title' => 'course_homepage']);
if (null === $homepageToolEntity) {
@error_log('[Migration Version20210930130343] Tool "course_homepage" not found. Skipping migration.');
return;
}

$q = $this->entityManager->createQuery('SELECT c FROM Chamilo\CoreBundle\Entity\Course c');

/** @var Course $course */
foreach ($q->toIterable() as $course) {
$courseId = $course->getId();
$sql = "SELECT * FROM c_tool_intro WHERE c_id = {$courseId}
ORDER BY iid";
$courseId = (int) $course->getId();
$sql = "SELECT * FROM c_tool_intro WHERE c_id = {$courseId} ORDER BY iid";
$result = $this->connection->executeQuery($sql);
$items = $result->fetchAllAssociative();

// If the course had no legacy intro rows, we still ensure the base homepage tool exists.
if (empty($items)) {
$admin = $this->getAdmin();
$tool = $toolRepo->findOneBy(['title' => 'course_homepage']);
$cTool = (new CTool())
$existingBaseTool = $cToolRepo->findOneBy([
'title' => 'course_homepage',
'course' => $course,
'session' => null,
]);

if ($existingBaseTool) {
// Nothing else to do for this course.
continue;
}

$baseTool = (new CTool())
->setTitle('course_homepage')
->setCourse($course)
->setTool($tool)
->setSession(null)
->setTool($homepageToolEntity)
->setCreator($admin)
->setParent($course)
->addCourseLink($course)
;
$this->entityManager->persist($cTool);
$this->entityManager->persist($baseTool);
$this->entityManager->flush();

continue;
}

foreach ($items as $itemData) {
$id = $itemData['iid'];
$sessionId = (int) $itemData['session_id'];
$toolName = $itemData['id'];
$id = (int) ($itemData['iid'] ?? 0);
if ($id <= 0) {
@error_log('[Migration Version20210930130343] Skipping legacy row with invalid iid. course_id='.$courseId);
continue;
}

$sessionId = (int) ($itemData['session_id'] ?? 0);
$toolName = (string) ($itemData['id'] ?? '');

/** @var CToolIntro $intro */
/** @var CToolIntro|null $intro */
$intro = $introRepo->find($id);
if (null === $intro) {
@error_log('[Migration Version20210930130343] CToolIntro entity not found for iid='.$id.' course_id='.$courseId);
continue;
}

// Already migrated.
if ($intro->hasResourceNode()) {
continue;
}

/** @var Session|null $session */
$session = null;
if (!empty($sessionId)) {
if ($sessionId > 0) {
$session = $sessionRepo->find($sessionId);
if ($session === null) {
if (null === $session) {
@error_log('[Migration Version20210930130343] Skipping intro iid='.$id.' because session_id='.$sessionId.' does not exist.');
continue;
}
}

$admin = $this->getAdmin();

// Reload course from repository to ensure it is managed in this context.
$managedCourse = $courseRepo->find($courseId);
if (null === $managedCourse) {
@error_log('[Migration Version20210930130343] Course not found for course_id='.$courseId.'. Skipping.');
continue;
}

/** @var CTool|null $cTool */
$cTool = null;
if ('course_homepage' === $toolName) {
$tool = $toolRepo->findOneBy(['title' => $toolName]);

if (null === $tool) {
continue;
if ('course_homepage' === $toolName) {
// avoid creating duplicate homepage tools.
// Reuse the existing tool for the same (course + session) context if it exists.
$cTool = $cToolRepo->findOneBy([
'title' => 'course_homepage',
'course' => $managedCourse,
'session' => $session,
]);

if (null === $cTool) {
$cTool = (new CTool())
->setTitle('course_homepage')
->setCourse($managedCourse)
->setSession($session)
->setTool($homepageToolEntity)
->setCreator($admin)
->setParent($managedCourse)
->addCourseLink($managedCourse, $session)
;

$this->entityManager->persist($cTool);
$this->entityManager->flush();
}

$course = $courseRepo->find($courseId);

$cTool = (new CTool())
->setTitle('course_homepage')
->setCourse($course)
->setSession($session)
->setTool($tool)
->setCreator($admin)
->setParent($course)
->addCourseLink($course, $session)
;
$this->entityManager->persist($cTool);
} else {
$cTool = $cToolRepo->findCourseResourceByTitle($toolName, $course->getResourceNode(), $course, $session);
$cTool = $cToolRepo->findCourseResourceByTitle(
$toolName,
$managedCourse->getResourceNode(),
$managedCourse,
$session
);
}

if (null === $cTool) {
@error_log('[Migration Version20210930130343] Could not resolve CTool for tool="'.$toolName.'" course_id='.$courseId.' session_id='.$sessionId);
continue;
}

// Attach intro to the correct tool/context and add resource node/links.
$intro
->setParent($course)
->setParent($managedCourse)
->setCourseTool($cTool)
;
$introRepo->addResourceNode($intro, $admin, $course);
$intro->addCourseLink($course, $session);

$introRepo->addResourceNode($intro, $admin, $managedCourse);
$intro->addCourseLink($managedCourse, $session);

$this->entityManager->persist($intro);
$this->entityManager->flush();
Expand Down
Loading