Comparer: zoom metric graph with the mouse wheel (#17)#40
Merged
Conversation
Add an X-axis frame range to MetricCal (mViewStartFrame/mViewEndFrame) and consult it instead of the whole parsed run when laying out samples. FrmsInfoView::OnMouseWheel forwards the cursor position to MetricCal::ZoomAtX, which zooms ~25% per notch and re-anchors the new view so the frame under the cursor stays at the same pixel. Double-clicking the graph restores the full-range view.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17.
MetricCal(mViewStartFrame/mViewEndFrame). Drawing now samples from the visible range instead of always from frame 0 to the last parsed frame.FrmsInfoView::OnMouseWheelforwards the cursor's X within the graph toMetricCal::ZoomAtX, which zooms ~25% per wheel notch and re-anchors the new range so the frame under the cursor stays at the same pixel.Update()callsResetView()).How to try