Comparer: highlight current frame with pane-specific color#42
Merged
Conversation
Add MetricCal::FrameAtX that maps a graph-area X pixel to a frame ID under the current view range, and let FrmsInfoView::OnLButtonDown use it to call SetScenes() and refresh the per-frame metric label. Combined with the recently-landed wheel zoom, the user can now zoom into a region of interest and click any point to jump straight to that frame. Double-click still resets the view, and clicks outside the graph area fall through to the default handler.
The timeline used to tint only the frame number text in the accent colour, which was easy to miss and identical for both panes. Now the whole row for the currently displayed frame is filled — blue for the left pane, warning-orange for the right pane — with the number drawn in surface white on top. The two panes are immediately distinguishable and the current frame jumps out of the timeline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously only the frame-number text in the timeline was tinted with the accent color, and both panes used the same color — easy to miss, impossible to tell apart at a glance.
This change fills the entire row of the current frame with a pane-specific color (blue for the left pane, orange for the right) and draws the number in surface white for contrast. Both panes are now immediately distinguishable and the current frame jumps out of the long timeline.
Try it