feat: enable to check auth token to github packages#219
feat: enable to check auth token to github packages#219LiKang6688 wants to merge 1 commit intochangesets:mainfrom
Conversation
🦋 Changeset detectedLatest commit: cf0d585 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LiKang6688
force-pushed
the
feat/auth-token
branch
from
3c43eb7 to
cf0d585
Compare
iansan5653
left a comment
iansan5653
left a comment
There was a problem hiding this comment.
We need this too -- our npmrc has a line that looks like:
//npm.pkg.github.com/:_authToken=${PACKAGES_TOKEN}
|
Time to merge? Note: it would be nice to create a new .npmrc file with |
|
Would you guys please merge this? |
|
I need it too. Please merge if it works! |
|
u nás sen říká ahoj tak ještě jednou ahoj omlouvám se, pokud se vyskytl
problém, tak se omlouvám, že mám tolik e-mailů půl vir sám mám problém s
jakou komunikací a githubem jsem požádal o pomoc a nasadil mě do tolika
vlaků, že nevím, co s tím žertem mohu pomoci tak prosím podrobný popis
toho, co jak kde rozumím těmto věcem velmi málo děkuji Marku a omlouvám se
za problém
út 21. 3. 2023 v 2:09 odesílatel Claudio Alcantara ***@***.***>
napsal:
… Would you guys please merge this?
I need it too.
—
Reply to this email directly, view it on GitHub
<#219 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AYJT2HCRXAD7FHXLIBP5X43W5D5VVANCNFSM6AAAAAAQ4TQGVE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
I need this as well. Would you guys please consider merging this? |
|
This one is critical to have, any estimates to accept this PR / or propose alternatives? |
|
Is there any chance this gets merged? Currently, it seems that GitHub Packages as NPM registry are not supported. |
| return /^\s*\/\/registry\.npmjs\.org\/:[_-]authToken=/i.test(line); | ||
| // npm Registry: check based on https://github.com/npm/cli/blob/8f8f71e4dd5ee66b3b17888faad5a7bf6c657eed/test/lib/adduser.js#L103-L105 | ||
| // GitHub Packages: check based on https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-npm-registry#authenticating-with-a-personal-access-token | ||
| return /^\s*\/\/registry\.npmjs\.org\/:[_-]authToken=/i.test(line) || /^\s*\/\/npm\.pkg\.github\.com\/:[_-]authToken=/i.test(line) |
There was a problem hiding this comment.
Shouldn't the regex here not be registry-specific but rather look for something more generic like just the :_authToken= part?
|
Any chance this will be merged soon? |
10 participants
solve #178