Skip to content

Don't error on symlinks and executables when they don't have to be touched anyway #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Andarist merged 12 commits into from
Jan 27, 2026
Merged

Don't error on symlinks and executables when they don't have to be touched anyway #46

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
104ac00
Don't error on symlinks and executables when they don't have to be to…
Andarist Jan 13, 2026
6e4f77f
update isomorphic-git
Andarist Jan 23, 2026
6b35465
tests
Andarist Jan 23, 2026
af4c42d
setup credentials
Andarist Jan 24, 2026
113aa27
update HEAD
Andarist Jan 25, 2026
0737341
use `setConfig`
Andarist Jan 25, 2026
294bf35
remove try/catch
Andarist Jan 25, 2026
432488d
push after commit
Andarist Jan 25, 2026
ded81ce
try different remote
Andarist Jan 26, 2026
8d7f0d3
tweak test helper
Andarist Jan 26, 2026
e5df86c
remove isomorphic-git's workaround
Andarist Jan 26, 2026
bec7822
changeset
Andarist Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/git.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,12 @@ export const commitChangesFromRepo = async ({
) {
return null;
}
const prevOid = await commit?.oid();
const currentOid = await workdir?.oid();
// Don't include files that haven't changed, and exist in both trees
if (prevOid === currentOid && !commit === !workdir) {
return null;
}
if (
(await commit?.mode()) === FILE_MODES.symlink ||
(await workdir?.mode()) === FILE_MODES.symlink
Expand All @@ -87,12 +93,6 @@ export const commitChangesFromRepo = async ({
`Unexpected executable file at ${filepath}, GitHub API only supports non-executable files and directories. You may need to add this file to .gitignore`,
);
}
const prevOid = await commit?.oid();
const currentOid = await workdir?.oid();
// Don't include files that haven't changed, and exist in both trees
if (prevOid === currentOid && !commit === !workdir) {
return null;
}
// Iterate through anything that may be a directory in either the
// current commit or the working directory
if (
Expand Down
Loading