Introducing 'preview_enabled' on the next_entity_type_config entity

[bojanbogdanovic]

This pull request is for: (mark with an "x")

• examples/*
• modules/next
• packages/next-drupal
• starters/basic-starter
• starters/graphql-starter
• Other

GitHub Issue: #496

Describe your changes

I have decoupled the site resolver from preview mode in the 'next_entity_type_config' and added a new 'preview_enabled' property. This property gives the ability to enable/disable the preview mode on specific entities. The site resolver is now also required, due the fact that it is needed for the preview mode and on demand revalidation.

Screenshot of the UI change:

[vercel]

@bojanbogdanovic is attempting to deploy a commit to the Chapter Three Team on Vercel.

A member of the Team first needs to authorize it.

[jeffschuler]

This is working for us, and very much needed. Thanks @bojanbogdanovic!

Here are the changes as a patch for the Next module in Drupal:
next_drupal-660-5c0d143.patch

[JohnAlbin]

Merge conflicts with a previous PR need to be resolved. Sorry about that!

[bojanbogdanovic]

Bump! Merge conflict is resolved.

[minnur]

This looks good to me.

[timdiels1]

When using the PR, I get errors when switching the plugin:

Warning: Undefined array key "site_resolver_settings_container" in Drupal\next\Form\NextEntityTypeConfigForm->ajaxReplaceSiteResolverSettingsForm() (line 250 of /var/www/html/drupal/web/modules/contrib/next/src/Form/NextEntityTypeConfigForm.php)

Something went wrong with the rebase?

Because the code is not showing the text for preview but for draft mode?

[timdiels1]

I'm not sure that I can do the changes directly in the PR. So this is the patch file that can be used for 2.x if you install the module from Drupal.org
next_drupal-660-c8f3000.patch

[bojanbogdanovic]

@timdiels1 I just pushed a fix, please take a look.

[timdiels1]

That will fix it yes, but then again I'm seeing still references to 'draft' in code while the screenshot you provided talks about the preview.

[bojanbogdanovic]

Yea the PR is pretty old and same goes for the screenshot, preview mode got changed to draft mode, see: 11e108a

I updated the key/label to make it consistent.

[timdiels1]

I see, thank you so much for the changes and explanation. Anyone following, please ignore my patch then and use the code changes that are now available.

[lincoln-c-dev]

Could someone clear up something for me please? Based on @bojanbogdanovic's comment, the pr has the most recent changes for this issue but for me the patch posted by @timdiels1 actually applied onto my site but obviously that's a bit older.

So I'm wondering how do i apply the changes of the pr itself? I tried adding .patch to the end of the pr url and then adding the resulting url to my composer.json on my drupal site but that failed to apply, what’s the correct way of getting these changes?