Skip to content

Fix PHP 8.4 incompatibility#869

Closed
arnested wants to merge 1 commit into
chapter-three:mainfrom
arnested:php8.4
Closed

Fix PHP 8.4 incompatibility#869
arnested wants to merge 1 commit into
chapter-three:mainfrom
arnested:php8.4

Conversation

@arnested

@arnested arnested commented Jul 29, 2025

Copy link
Copy Markdown

The module throws some warnings about "Implicitly marking a parameter as nullable is deprecated since PHP 8.4."

This pull request is for: (mark with an "x")

  • examples/*
  • modules/next
  • packages/next-drupal
  • starters/basic-starter
  • starters/graphql-starter
  • starters/pages-starter
  • Other

GitHub Issue: #870

  • I need help adding tests. (mark with an "x")
    Code changes need test coverage. If you don't know
    how to make tests, check this box to ask for help.

Describe your changes

Adjusts the method signatures regarding implicit nullable parameters to be compatible with PHP 8.4.

The module throws some warnings about "Implicitly marking a parameter as nullable is deprecated since PHP 8.4."
@vercel

vercel Bot commented Jul 29, 2025

Copy link
Copy Markdown

@arnested is attempting to deploy a commit to the Chapter Three Team on Vercel.

A member of the Team first needs to authorize it.

@arnested arnested mentioned this pull request Jul 29, 2025
@boazpoolman

boazpoolman commented Aug 15, 2025

Copy link
Copy Markdown

Thanks for this @arnested.

Just adding a patch here with your changes so that I can apply it in my composer.json.

php-8-4-compatibility.patch

@arnested arnested closed this by deleting the head repository Aug 24, 2025
@arnested arnested mentioned this pull request Oct 18, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants