Merge pull request #1 from char8x/feat_disable_selection_highlight

feat: notify configuration reload

Author: char8x

.gitignore

@@ -3,3 +3,4 @@ dist
 node_modules
 .vscode-test/
 *.vsix
+test-fixture/.vscode/

.vscode/tasks.json

@@ -107,7 +107,7 @@
             "id": "terminateAll",
             "type": "command",
             "command": "workbench.action.tasks.terminate",
-            "args": "terminateAll" // 终止所有运行任务；如果只想终止特定任务，可手动选择
+            "args": "terminateAll"
         }
     ]
 }

package.json

@@ -27,8 +27,7 @@
           "description": "Rendering styles for irrelevant code",
           "default": {
             "opacity": "0.2",
-            "backgroundColor": "transparent",
-            "border": "none"
+            "backgroundColor": "transparent"
           }
         },
         "codeFader.autoUnfold": {

src/extension.ts

@@ -144,31 +144,59 @@ async function calculateRanges(
   );
 }
 
-export async function activate(context: vscode.ExtensionContext) {
+function loadSettings() {
   const config = vscode.workspace.getConfiguration();
-  let isEnabled = config.get<boolean>('codeFader.enabled');
-  const isAutoUnfold = config.get<boolean>('codeFader.autoUnfold');
+
   const decorationSetting = Object.assign(
     {
       opacity: '0.2',
       backgroundColor: 'transparent',
-      border: 'none',
     } as vscode.ThemableDecorationRenderOptions,
     config.get<vscode.ThemableDecorationRenderOptions>('codeFader.decoration')
   );
   let codeDecoration =
     vscode.window.createTextEditorDecorationType(decorationSetting);
 
+  let isEnabled = config.get<boolean>('codeFader.enabled');
+  const isAutoUnfold = config.get<boolean>('codeFader.autoUnfold');
+
+  return { isEnabled, codeDecoration, isAutoUnfold };
+}
+
+function subscribeSelectionHighlightBorderChange(
+  context: vscode.ExtensionContext
+) {
+  let isPromptVisible = false;
+
+  async function showReloadPrompt() {
+    if (isPromptVisible) return;
+
+    isPromptVisible = true;
+    const selection = await vscode.window.showInformationMessage(
+      'Configuration changes have been detected. Reload now?',
+      'Reload'
+    );
+    isPromptVisible = false;
+
+    if (selection === 'Reload') {
+      vscode.commands.executeCommand('workbench.action.reloadWindow');
+    }
+  }
+
+  // Listen for Configuration Change Events
   context.subscriptions.push(
     vscode.workspace.onDidChangeConfiguration((event) => {
       if (event.affectsConfiguration('codeFader.enabled')) {
-        const updatedValue = vscode.workspace
-          .getConfiguration()
-          .get<boolean>('codeFader.enabled');
-        isEnabled = updatedValue;
+        showReloadPrompt();
       }
     })
   );
+}
+
+export async function activate(context: vscode.ExtensionContext) {
+  subscribeSelectionHighlightBorderChange(context);
+
+  let { isEnabled, codeDecoration, isAutoUnfold } = loadSettings();
 
   let selectionVersion = 0;
 

test-fixture/.gitignore

@@ -0,0 +1 @@
+.vscode/

test-fixture/.vscode/settings.json

@@ -1,3 +1,7 @@
 {
-  "editor.selectionHighlight": true
+  "editor.selectionHighlight": true,
+  "codeFader.enabled": true,
+  "workbench.colorCustomizations": {
+    "editor.selectionHighlightBorder": "default"
+  }
 }