fix(textinput): account for horizontal scroll offset in Cursor()

Author: guptarohit

textinput/textinput.go

@@ -921,8 +921,9 @@ func (m Model) Cursor() *tea.Cursor {
 	w := lipgloss.Width
 
 	promptWidth := w(m.promptView())
-	xOffset := m.Position() +
-		promptWidth
+	// Like View, use the scroll-adjusted column (pos-offset) so the cursor
+	// tracks the visible position when the value overflows the width.
+	xOffset := max(0, m.pos-m.offset) + promptWidth
 	if m.width > 0 {
 		xOffset = min(xOffset, m.width+promptWidth)
 	}

textinput/textinput_test.go

@@ -7,6 +7,7 @@ import (
 	"testing"
 
 	tea "charm.land/bubbletea/v2"
+	"charm.land/lipgloss/v2"
 )
 
 func Test_CurrentSuggestion(t *testing.T) {
@@ -118,3 +119,35 @@ func sendString(m Model, str string) Model {
 
 	return m
 }
+
+// See #1001: Cursor() must use the scroll-adjusted column (pos-offset) like View().
+func TestCursorXAccountsForScrollOffset(t *testing.T) {
+	m := New()
+	m.Focus()
+	m.SetVirtualCursor(false)
+	m.CharLimit = 200
+	m.SetWidth(20)
+	m.SetValue(strings.Repeat("a", 30))
+
+	// Scroll to the end, then move into the middle of the viewport, where the
+	// width clamp doesn't mask the wrong column.
+	m.CursorEnd()
+	m.SetCursor(25)
+
+	if m.offset == 0 {
+		t.Fatalf("test setup: expected a non-zero scroll offset for an overflowing input, got 0")
+	}
+
+	cur := m.Cursor()
+	if cur == nil {
+		t.Fatal("Cursor() returned nil")
+	}
+
+	promptWidth := lipgloss.Width(m.promptView())
+	want := promptWidth + (m.pos - m.offset)
+	if cur.X != want {
+		t.Errorf("Cursor().X = %d, want %d (promptWidth=%d, pos=%d, offset=%d); "+
+			"Cursor() must use the scroll-adjusted column (pos-offset) like View(), not the absolute Position()",
+			cur.X, want, promptWidth, m.pos, m.offset)
+	}
+}