fix(list): convert fuzzy match indexes from byte to rune offsets#1014
Open
upuddu wants to merge 1 commit into
Open
fix(list): convert fuzzy match indexes from byte to rune offsets#1014upuddu wants to merge 1 commit into
upuddu wants to merge 1 commit into
Conversation
sahilm/fuzzy reports MatchedIndexes as byte offsets, but MatchesForItem documents them as rune positions and lipgloss.StyleRunes consumes them as such. For targets containing multi-byte characters this highlighted the wrong runes (or none). Convert the offsets in DefaultFilter and UnsortedFilter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sahilm/fuzzyreportsMatchedIndexesas byte offsets, butMatchesForItemdocuments them as rune positions andlipgloss.StyleRunesconsumes them as such - so filtering a list whose item titles contain multi-byte characters (CJK, accents, emoji) highlighted the wrong runes, or none. This converts the offsets from byte to rune positions inDefaultFilterandUnsortedFilter.Fixes #124