Fix ast calls in wait.py for python 3.14 (#306)

* Fix ast calls in wait.py for python 3.14

* trigger workflow

* changing github workflows

* jacobi bool error and workflow change

* test config change

* exclude test

* fix schedule cb test

Author: ritvikrao

.github/workflows/charm4py.yml

@@ -13,12 +13,12 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        python-version: ["3.8", "3.12"]
+        python-version: ["3.10", "3.12", "3.14"]
         # macos-13 is x86_64, macos-14 is arm64
-        os: [ubuntu-latest, macos-13, macos-14]
+        os: [ubuntu-latest, macos-14, macos-15, macos-26]
         exclude:
-          - os: ubuntu-latest # Python 3.8 not supported since ubuntu 24.04
-            python-version: "3.8"
+          - os: macos-26
+            python-version: "3.14"
       fail-fast: false
 
     steps:
@@ -32,17 +32,13 @@ jobs:
       - name: Install dependencies
         run: |
           pip install setuptools cython cffi greenlet numpy torch torchvision filelock matplotlib
-          if [ ${{ matrix.os }} == 'macos-13' ]; then
-            # pypi only distributes torch packages w/ numpy v1 for macos-x86_64
-            pip install 'numpy<2'
-          fi
       - name: Build Charm++/Charm4py
         run: |
           git clone https://github.com/charmplusplus/charm charm_src/charm
           export CHARM_EXTRA_BUILD_OPTS="--enable-error-checking"
           export CHARM_BUILD_PROCESSES=8
           export CHARM4PY_BUILD_CFFI=1
-          python setup.py build_ext --inplace
+          pip install -e .
       - name: Run auto_test.py
         run: |
           export PYTHONPATH="$PWD"

charm4py/wait.py

@@ -188,9 +188,7 @@ def is_tag_cond(root_ast):
             return None
 
         idx = args.slice.value
-        if isinstance(idx, ast.Num):
-            idx = idx.n
-        elif isinstance(idx, ast.Constant):
+        if isinstance(idx, ast.Constant):
             idx = idx.value
 
         if not isinstance(idx, int):
@@ -214,7 +212,7 @@ def visit_Attribute(self, node):
             return ast.copy_location(ast.Attribute(
                 value=ast.Subscript(
                     value=ast.Name(id='args', ctx=ast.Load()),
-                    slice=ast.Index(value=ast.Num(n=idx)),
+                    slice = ast.Constant(value=idx),
                     ctx=node.ctx
                 ),
                 attr=node.attr,
@@ -229,7 +227,7 @@ def visit_Name(self, node):
             self.num_msg_args += 1
             return ast.copy_location(ast.Subscript(
                 value=ast.Name(id='args', ctx=ast.Load()),
-                slice=ast.Index(value=ast.Num(n=idx)),
+                slice = ast.Constant(value=idx),
                 ctx=node.ctx
             ), node)
         else:

docs/install.rst

@@ -7,7 +7,7 @@ Install
 Charm4py runs on Linux, macOS, Windows, Raspberry Pi, and a wide variety of clusters and
 supercomputer environments (including many supercomputers in the TOP500).
 
-Charm4py runs on Python 3.8+. Charm4py supports the CPython Python implementation.
+Charm4py runs on Python 3.9+. Charm4py supports the CPython Python implementation.
 
 Installing Charm4Py binaries (via pip)
 ---------------------------------------

examples/jacobi/jacobi2d.py

@@ -101,7 +101,7 @@ def run(self):
             max_error = check_and_compute(self.temperature, self.new_temperature,
                                           self.istart, self.ifinish, self.jstart, self.jfinish)
             self.temperature, self.new_temperature = self.new_temperature, self.temperature
-            converged = self.allreduce(max_error <= THRESHOLD, Reducer.logical_and).get()
+            converged = self.allreduce(bool(max_error <= THRESHOLD), Reducer.logical_and).get()
             iteration += 1
 
         if self.thisIndex == (0, 0):

tests/callbacks/schedule_cb.py

@@ -14,9 +14,11 @@ def start(self):
         charm.scheduleCallableAfter(self.thisProxy[self.thisIndex].next, 1, [-1])
 
     def next(self, from_elem):
-        print(self.thisIndex, 'time=', time() - self.t0, 'from=', from_elem)
+        elapsed = time() - self.t0
+        print(self.thisIndex, 'time=', elapsed, 'from=', from_elem)
         assert from_elem == self.thisIndex[0] - 1
-        assert time() - self.t0 > self.thisIndex[0] + 0.9
+        expected = self.thisIndex[0] + 1.0
+        assert elapsed >= expected - 0.5, (self.thisIndex[0], elapsed, expected)
         if self.thisIndex[0] == NUM_CHARES - 1:
             print('DONE')
             exit()