Skip to content

Commit 28f8b50

Browse files
author
iexitdev
authored
Merge pull request #748 from capelski/on-press-fix
Fix onDataPointClick not being triggered on LineChart dots
2 parents 9a8c11e + df05988 commit 28f8b50

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

src/line-chart/LineChart.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ class LineChart extends AbstractChart<LineChartProps, LineChartState> {
293293
((baseHeight - this.calcHeight(x, datas, height)) / 4) * 3 +
294294
paddingTop;
295295

296-
const onPress = () => {
296+
const onPressIn = () => {
297297
if (!onDataPointClick || hidePointsAtIndex.includes(i)) {
298298
return;
299299
}
@@ -318,7 +318,7 @@ class LineChart extends AbstractChart<LineChartProps, LineChartState> {
318318
? getDotColor(x, i)
319319
: this.getColor(dataset, 0.9)
320320
}
321-
onPress={onPress}
321+
onPressIn={onPressIn}
322322
{...this.getPropsForDots(x, i)}
323323
/>,
324324
<Circle
@@ -328,7 +328,7 @@ class LineChart extends AbstractChart<LineChartProps, LineChartState> {
328328
r="14"
329329
fill="#fff"
330330
fillOpacity={0}
331-
onPress={onPress}
331+
onPressIn={onPressIn}
332332
/>,
333333
<React.Fragment key={`dot-content-${datasetIndex}-${i}`}>
334334
{renderDotContent({ x: cx, y: cy, index: i, indexData: x })}

0 commit comments

Comments
 (0)