feat: Make quality of images sent in chats more consistent

Currently, the resolution of a resized image that was sent in a chat,
depends on the aspect-ratio.

Assuming the `balanced`-quality-setting is used,
a square image, that is larger than the limits for resolution and file-size,
will be resized to 1280x1280 (1,638,400 pixels),
an image with an aspect-ratio of 16:9,
will be resized to 1280x720 (921,600 pixels),
and if the aspect-ratio is 32:9, to 1280x360 (460,800 pixels).

This change makes it so, that the number of pixels,
in images with different aspect-ratios, will be similar.

Author: 72374

src/blob.rs

@@ -429,13 +429,25 @@ impl<'a> BlobObject<'a> {
                         });
 
             if do_scale {
+                let resolution_of_longest_side_of_image = max(img.width(), img.height());
+                let square_root_of_number_of_pixels_in_image =
+                    f64::from(img.width() * img.height()).sqrt();
+
                 // target_wh will be used as the target-resolution for resizing the image,
                 // so that the longest sides of the image match the target-resolution,
                 // without changing the aspect-ratio.
-                let mut target_wh = if exceeds_wh {
-                    max_wh
+                let mut target_wh = if !is_avatar && exceeds_wh {
+                    // Limit resolution to the number of pixels that fit within max_wh * max_wh,
+                    // so that the image-quality does not depend on the aspect-ratio.
+                    (f64::from(resolution_of_longest_side_of_image)
+                        * (f64::from(max_wh) / square_root_of_number_of_pixels_in_image))
+                        as u32
                 } else {
-                    max(img.width(), img.height())
+                    max_wh
+                };
+
+                if target_wh > resolution_of_longest_side_of_image {
+                    target_wh = resolution_of_longest_side_of_image
                 };
 
                 loop {

src/blob/blob_tests.rs

@@ -384,8 +384,8 @@ async fn test_recode_image_balanced_png() {
         extension: "png",
         original_width: 1920,
         original_height: 1080,
-        compressed_width: constants::WORSE_IMAGE_SIZE,
-        compressed_height: constants::WORSE_IMAGE_SIZE * 1080 / 1920,
+        compressed_width: 853,
+        compressed_height: 480,
         ..Default::default()
     }
     .test()
@@ -475,8 +475,8 @@ async fn test_recode_image_rgba_png_to_jpeg() {
         extension: "png",
         original_width: 1920,
         original_height: 1080,
-        compressed_width: constants::WORSE_IMAGE_SIZE,
-        compressed_height: constants::WORSE_IMAGE_SIZE * 1080 / 1920,
+        compressed_width: 853,
+        compressed_height: 480,
         ..Default::default()
     }
     .test()
@@ -495,8 +495,8 @@ async fn test_recode_image_huge_jpg() {
         has_exif: true,
         original_width: 1920,
         original_height: 1080,
-        compressed_width: constants::BALANCED_IMAGE_SIZE,
-        compressed_height: constants::BALANCED_IMAGE_SIZE * 1080 / 1920,
+        compressed_width: 1706,
+        compressed_height: 960,
         ..Default::default()
     }
     .test()

src/tests/pre_messages/additional_text.rs

@@ -34,7 +34,7 @@ async fn test_additional_text_on_different_viewtypes() -> Result<()> {
     let (pre_message, _, _) = send_large_image_message(alice, a_group_id).await?;
     let msg = bob.recv_msg(&pre_message).await;
     assert_eq!(msg.text, "test".to_owned());
-    assert_eq!(msg.get_text(), "test [Image – 146.12 KiB]".to_owned());
+    assert_eq!(msg.get_text(), "test [Image – 227.50 KiB]".to_owned());
 
     Ok(())
 }

src/tests/pre_messages/receiving.rs

@@ -323,9 +323,9 @@ async fn test_receive_pre_message_image() -> Result<()> {
     // test that metadata is correctly returned by methods
     assert_eq!(msg.get_post_message_viewtype(), Some(Viewtype::Image));
     // recoded image dimensions
-    assert_eq!(msg.get_filebytes(bob).await?, Some(149632));
-    assert_eq!(msg.get_height(), 1280);
-    assert_eq!(msg.get_width(), 720);
+    assert_eq!(msg.get_filebytes(bob).await?, Some(232957));
+    assert_eq!(msg.get_height(), 1706);
+    assert_eq!(msg.get_width(), 960);
 
     Ok(())
 }