Conversation
…efore sending outgoing one We don't want to send an outgoing message from the 2nd device (`ac1_clone`) before receiving the incoming one and expect that the messages will be ordered correctly on the 1st device (`ac1`). Let's ensure the correct message order locally in the first place. I checked logs of a failed test run and it indeed happened that `ac1_clone` sent the message earlier, so it can't reference the incoming message and `tweak_sort_timestamp()` does nothing on `ac1`, so the messages can't be ordered correctly considering that smeared clocks on the devices are diferent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't want to send an outgoing message from the 2nd device (
ac1_clone) before receiving the incoming one and expect that the messages will be ordered correctly on the 1st device (ac1). Let's ensure the correct message order locally in the first place. I checked logs of a failed test run and it indeed happened thatac1_clonesent the message earlier, so it can't reference the incoming message andtweak_sort_timestamp()does nothing onac1, so the messages can't be ordered correctly considering that smeared clocks on the devices are different.