config: validate domains when formatting them

Author: missytake

chatmaild/pyproject.toml

@@ -10,6 +10,7 @@ dependencies = [
   "filelock",
   "requests",
   "crypt-r >= 3.13.1 ; python_version >= '3.11'",
+  "domain-validator",
 ]
 
 [tool.setuptools]

chatmaild/src/chatmaild/config.py

@@ -3,6 +3,7 @@
 from pathlib import Path
 
 import iniconfig
+from domain_validator import DomainValidator
 
 from chatmaild.user import User
 
@@ -178,10 +179,12 @@ def format_arpa_address(address: str) -> str:
     if is_valid_ipv4(address):
         parts = address.split(".")
         return f"{parts[3]}.{parts[2]}.{parts[1]}.{parts[0]}.in-addr.arpa"
+    DomainValidator().validate_domain_re(address)
     return address
 
 
 def format_deliverable_domain(mail_domain: str) -> str:
     if is_valid_ipv4(mail_domain):
         return f"[{mail_domain}]"
+    DomainValidator().validate_domain_re(mail_domain)
     return mail_domain

chatmaild/src/chatmaild/tests/test_config.py

@@ -1,6 +1,8 @@
+from contextlib import nullcontext as does_not_raise
+
 import pytest
 
-from chatmaild.config import read_config
+from chatmaild.config import read_config, is_valid_ipv4, format_arpa_address, format_deliverable_domain
 
 
 def test_read_config_basic(example_config):
@@ -16,6 +18,11 @@ def test_read_config_basic(example_config):
     assert example_config.mail_domain_deliverable == "chat.example.org"
 
 
+def test_read_config_deliverable(ipv4_config):
+    assert ipv4_config.mail_domain == "1.3.3.7"
+    assert ipv4_config.mail_domain_deliverable == "[1.3.3.7]"
+
+
 def test_read_config_basic_using_defaults(tmp_path, maildomain):
     inipath = tmp_path.joinpath("chatmail.ini")
     inipath.write_text(f"[params]\nmail_domain = {maildomain}")
@@ -122,3 +129,45 @@ def test_config_tls_external_bad_format(make_config):
                 "tls_external_cert_and_key": "/only/one/path.pem",
             },
         )
+
+
+@pytest.mark.parametrize(
+    ["input", "result"],
+    [
+        ("example.org", False),
+        ("1.3.3.7", True),
+        ("fe::1", False),
+        ("ad.1e.dag.adf", False),
+        ("12394142", False),
+    ]
+)
+def test_is_valid_ipv4(input, result):
+    assert result == is_valid_ipv4(input)
+
+
+@pytest.mark.parametrize(
+    ["input", "result", "exception"],
+    [
+        ("example.org", "example.org", does_not_raise()),
+        ("1.3.3.7", "7.3.3.1.in-addr.arpa", does_not_raise()),
+        ("fe::1", None, pytest.raises(ValueError)),
+        ("12394142", None, pytest.raises(ValueError)),
+    ]
+)
+def test_format_arpa_address(input, result, exception):
+    with exception:
+        assert result == format_arpa_address(input)
+
+
+@pytest.mark.parametrize(
+    ["input", "result", "exception"],
+    [
+        ("example.org", "example.org", does_not_raise()),
+        ("1.3.3.7", "[1.3.3.7]", does_not_raise()),
+        ("fe::1", None, pytest.raises(ValueError)),
+        ("12394142", None, pytest.raises(ValueError)),
+    ]
+)
+def test_format_deliverable_domain(input, result, exception):
+    with exception:
+        assert result == format_deliverable_domain(input)

cmdeploy/src/cmdeploy/tests/test_cmdeploy.py

@@ -40,8 +40,6 @@ def test_init_not_overwrite(self, capsys, tmp_path, monkeypatch):
         assert "deleting config file" in out.lower()
 
     def test_dns_skip_on_ip(self, capsys):
-        parser = get_parser()
-        parser.parse_args([])
         assert main(["init", "1.3.3.7"]) == 0
         assert main(["dns"]) == 0
         out, err = capsys.readouterr()