chore: Clean up

Author: iamsivin

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@chatwoot/utils",
-  "version": "0.0.54",
+  "version": "0.0.55",
   "description": "Chatwoot utils",
   "private": false,
   "license": "MIT",

src/fileUploadRules.ts

@@ -54,7 +54,7 @@ export const INBOX_TYPES = {
 } as const;
 
 // derive key type AFTER INBOX_TYPES is declared
-type ChannelKey = typeof INBOX_TYPES[keyof typeof INBOX_TYPES];
+type ChannelKey = (typeof INBOX_TYPES)[keyof typeof INBOX_TYPES];
 
 // CHANNEL_CONFIGS shape: channels are optional; default node requires max
 type ChannelConfigs = Partial<Record<ChannelKey, ChannelConfig>> & {
@@ -88,33 +88,36 @@ type ChannelConfigs = Partial<Record<ChannelKey, ChannelConfig>> & {
  *  2. channel + "*" fallback
  *  3. global default
  */
+
+const STANDARD_TEXT_MIMES = ['csv', 'plain', 'rtf', 'xml'];
+const STANDARD_APPLICATION_MIMES = [
+  'json',
+  'pdf',
+  'xml',
+  'zip',
+  'x-7z-compressed',
+  'vnd.rar',
+  'x-tar',
+  'msword',
+  'vnd.ms-excel',
+  'vnd.ms-powerpoint',
+  'vnd.oasis.opendocument.text',
+  'vnd.openxmlformats-officedocument.presentationml.presentation',
+  'vnd.openxmlformats-officedocument.spreadsheetml.sheet',
+  'vnd.openxmlformats-officedocument.wordprocessingml.document',
+];
+const STANDARD_EXTENSIONS = ['.3gpp', '.xls', '.xlsx'];
+
 const CHANNEL_CONFIGS: ChannelConfigs = {
   default: {
     mimeGroups: {
       image: ['*'],
       audio: ['*'],
       video: ['*'],
-      text: ['csv', 'plain', 'rtf', 'xml'],
-      application: [
-        'json',
-        'pdf',
-        'xml',
-        'zip',
-        'x-7z-compressed',
-        'vnd.rar',
-        'x-tar',
-        'msword',
-        'vnd.ms-excel',
-        'vnd.ms-powerpoint',
-        'vnd.oasis.opendocument.text',
-        'vnd.openxmlformats-officedocument.presentationml.presentation',
-        'vnd.openxmlformats-officedocument.spreadsheetml.sheet',
-        'vnd.openxmlformats-officedocument.wordprocessingml.document',
-        'x-pkcs12',
-        'pkcs12',
-      ],
+      text: STANDARD_TEXT_MIMES,
+      application: [...STANDARD_APPLICATION_MIMES, 'x-pkcs12', 'pkcs12'],
     },
-    extensions: ['.3gpp', '.xls', '.xlsx', '.pfx'],
+    extensions: [...STANDARD_EXTENSIONS, '.pfx'],
     max: 40,
   },
 
@@ -193,7 +196,17 @@ const CHANNEL_CONFIGS: ChannelConfigs = {
   },
 
   [INBOX_TYPES.TWILIO]: {
-    sms: { max: 5 },
+    sms: {
+      mimeGroups: {
+        image: ['jpeg', 'png'],
+        audio: ['*'],
+        video: ['*'],
+        text: STANDARD_TEXT_MIMES,
+        application: STANDARD_APPLICATION_MIMES,
+      },
+      extensions: STANDARD_EXTENSIONS,
+      max: 5,
+    },
     whatsapp: {
       mimeGroups: {
         image: ['png', 'jpeg'],

test/fileUploadRules.test.ts

@@ -1,7 +1,7 @@
 import {
-  INBOX_TYPES,
   getAllowedFileTypesByChannel,
   getMaxUploadSizeByChannel,
+  INBOX_TYPES,
 } from '../src/fileUploadRules';
 
 describe('uploadRules helper', () => {
@@ -15,6 +15,9 @@ describe('uploadRules helper', () => {
       expect(accept).toContain('text/plain');
       expect(accept).toContain('application/json');
       expect(accept).toContain('.3gpp');
+      expect(accept).toContain('application/x-pkcs12');
+      expect(accept).toContain('application/pkcs12');
+      expect(accept).toContain('.pfx');
     });
 
     it('returns WhatsApp specific accept list', () => {
@@ -33,6 +36,8 @@ describe('uploadRules helper', () => {
       expect(accept).not.toContain('application/json');
       expect(accept).not.toContain('.3gpp');
       expect(accept).not.toContain('image/gif');
+      expect(accept).not.toContain('application/x-pkcs12');
+      expect(accept).not.toContain('.pfx');
     });
 
     it('returns Instagram specific accept list', () => {
@@ -73,13 +78,25 @@ describe('uploadRules helper', () => {
       expect(accept).not.toContain('audio/mp3');
     });
 
-    it('falls back to default accept list for Twilio SMS (no mimeGroups)', () => {
+    it('returns Twilio SMS accept list (default-aligned, excluding PFX)', () => {
       const accept = getAllowedFileTypesByChannel({
         channelType: INBOX_TYPES.TWILIO,
         medium: 'sms',
       });
-      expect(accept).toContain('image/*');
+      expect(accept).toContain('image/jpeg');
+      expect(accept).toContain('image/png');
+      expect(accept).not.toContain('image/*');
+      expect(accept).not.toContain('image/gif');
+      expect(accept).toContain('audio/*');
+      expect(accept).toContain('video/*');
+      expect(accept).toContain('text/plain');
+      expect(accept).toContain('application/pdf');
+      expect(accept).toContain('application/json');
       expect(accept).toContain('.3gpp');
+      expect(accept).toContain('.xls');
+      expect(accept).not.toContain('application/x-pkcs12');
+      expect(accept).not.toContain('application/pkcs12');
+      expect(accept).not.toContain('.pfx');
     });
 
     it('handles empty object parameter', () => {