Restore C#/Python client customizations to avoid SDK breaking changes#1
Closed
rishchou wants to merge 1 commit into
Closed
Conversation
…eaking changes Reverts the accidental removal of csharp @@clientName/@@alternateType/@@Usage decorators and python client-name/enum mitigations, and restores the !csharp scope in back-compatible.tsp. Keeps the shipped SDK surface stable for Azure.ResourceManager.BillingBenefits (C#) and azure-mgmt-billingbenefits (Python). Addresses review feedback from @msyyc.
Next Steps to MergeImportant checks have failed. As of today they are not blocking this PR, but in near future they may.Addressing the following failures is highly recommended:
Comment generated by summarize-checks workflow run. |
ryanmaley310
approved these changes
Jul 1, 2026
sornaks
approved these changes
Jul 1, 2026
gaoyp830
approved these changes
Jul 1, 2026
ryanmaley310
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the C#/Python client customizations that were inadvertently removed from
client.tsp(and the!csharpscope inback-compatible.tsp) in PR Azure#44111.The reduction would break the shipped
Azure.ResourceManager.BillingBenefits(C#) andazure-mgmt-billingbenefits(Python) SDKs by dropping all@@clientName/@@alternateType/@@usagedecorators and Python enum/client-name mitigations. This restores them so the SDK surface stays stable. Addresses @msyyc review feedback.Verified locally:
tsp compilepasses (including--warn-as-error); onlyclient.tspandback-compatible.tspchange; generated swagger is unaffected.