don't change functionality

Author: chdsbd

src/providers.ts

@@ -113,10 +113,6 @@ export class Github extends BaseProvider {
   PROVIDER_NAME = "github"
 
   buildLines({ start, end }: ISelection): string {
-    if (start.line === end.line && start.character === end.character) {
-      return ""
-    }
-
     let line = `L${start.line + 1}`
     if (start.character !== 0) {
       line += `C${start.character + 1}`

src/test/suite/providers.test.ts

@@ -40,7 +40,7 @@ suite("Github", async () => {
       "git@github.com:recipeyak/recipeyak",
       "org-XYZ123@github.com:recipeyak/recipeyak",
     ]) {
-      const findRemote = async (hostname: string) => {
+      async function findRemote(hostname: string) {
         return url
       }
       const gh = new Github({}, "origin", findRemote)
@@ -75,7 +75,7 @@ suite("Github", async () => {
       "org-XYZ123@github.mycompany.com:recipeyak/recipeyak",
       "ssh://git@github.mycompany.com/recipeyak/recipeyak.git",
     ]) {
-      const findRemote = async (hostname: string) => {
+      async function findRemote(hostname: string) {
         return url
       }
       const gh = new Github(
@@ -116,7 +116,7 @@ suite("Github", async () => {
       "org-XYZ123@github.mycompany.com:recipeyak/recipeyak",
       "ssh://git@github.mycompany.com/recipeyak/recipeyak.git",
     ]) {
-      const findRemote = async (hostname: string) => {
+      async function findRemote(hostname: string) {
         return url
       }
       const gh = new Github(
@@ -150,47 +150,6 @@ suite("Github", async () => {
       assert.deepEqual(result, expected)
     }
   })
-  test("if we have no selection on the first line, don't select anything", async () => {
-    for (let url of [
-      "git@github.mycompany.com:recipeyak/recipeyak.git",
-      "git@github.mycompany.com:recipeyak/recipeyak",
-      "org-XYZ123@github.mycompany.com:recipeyak/recipeyak",
-      "ssh://git@github.mycompany.com/recipeyak/recipeyak.git",
-    ]) {
-      const findRemote = async (hostname: string) => {
-        return url
-      }
-      const gh = new Github(
-        {
-          github: { hostnames: ["github.mycompany.com"] },
-        },
-        "origin",
-        findRemote,
-      )
-      const result = await gh.getUrls({
-        selection: {
-          start: { line: 0, character: 0 },
-          end: { line: 0, character: 0 },
-        },
-        head: createBranch("master"),
-        relativeFilePath: "frontend/src/components/App.tsx",
-      })
-      const expected = {
-        blobUrl:
-          "https://github.mycompany.com/recipeyak/recipeyak/blob/master/frontend/src/components/App.tsx",
-        blameUrl:
-          "https://github.mycompany.com/recipeyak/recipeyak/blame/master/frontend/src/components/App.tsx",
-        compareUrl:
-          "https://github.mycompany.com/recipeyak/recipeyak/compare/master",
-        historyUrl:
-          "https://github.mycompany.com/recipeyak/recipeyak/commits/master/frontend/src/components/App.tsx",
-        prUrl:
-          "https://github.mycompany.com/recipeyak/recipeyak/pull/new/master",
-        repoUrl: "https://github.mycompany.com/recipeyak/recipeyak",
-      }
-      assert.deepEqual(result, expected)
-    }
-  })
 })
 
 suite("Gitlab", async () => {