Skip to content

Commit 3af93dd

Browse files
danielpaulusclaude
andauthored
refactor(grpc): drop storeResponseBody from GrpcMonitor request (#1413)
gRPC checks always store the response body now — the backend removed the per-check "store response body" toggle and no longer accepts or returns the field. Remove it from the GrpcRequest construct type and the codegen emitter, and drop it from the affected fixtures. Claude-Session: https://claude.ai/code/session_013AYwkvoaANQTH5dGStbBj2 Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent b6e0d74 commit 3af93dd

5 files changed

Lines changed: 0 additions & 14 deletions

File tree

packages/cli/src/constructs/__tests__/grpc-monitor.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@ describe('GrpcMonitor', () => {
6262
grpcConfig: {
6363
mode: 'BEHAVIOR',
6464
tls: true,
65-
storeResponseBody: true,
6665
serviceDefinition: 'REFLECTION',
6766
method: '/grpc.health.v1.Health/Check',
6867
},

packages/cli/src/constructs/__tests__/uptime-monitor-codegen.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ describe('GrpcMonitorCodegen', () => {
7474
grpcConfig: {
7575
mode: 'BEHAVIOR',
7676
tls: true,
77-
storeResponseBody: true,
7877
serviceDefinition: 'REFLECTION',
7978
method: '/grpc.health.v1.Health/Check',
8079
},

packages/cli/src/constructs/__tests__/uptime-monitor-export-snippets.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ describe('backend-style export snippets', () => {
3636
grpcConfig: {
3737
mode: 'BEHAVIOR',
3838
tls: true,
39-
storeResponseBody: true,
4039
serviceDefinition: 'REFLECTION',
4140
method: '/grpc.health.v1.Health/Check',
4241
},

packages/cli/src/constructs/grpc-request-codegen.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,6 @@ export function valueForGrpcRequest (
3535
builder.boolean('tls', config.tls)
3636
}
3737

38-
if (config.storeResponseBody !== undefined) {
39-
builder.boolean('storeResponseBody', config.storeResponseBody)
40-
}
41-
4238
if (config.serviceDefinition) {
4339
builder.string('serviceDefinition', config.serviceDefinition)
4440
}

packages/cli/src/constructs/grpc-request.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -52,13 +52,6 @@ export interface GrpcConfig {
5252
*/
5353
tls?: boolean
5454

55-
/**
56-
* Whether to store the gRPC response body with the check result.
57-
*
58-
* @defaultValue true
59-
*/
60-
storeResponseBody?: boolean
61-
6255
/**
6356
* gRPC metadata (request headers) sent with the call.
6457
*/

0 commit comments

Comments
 (0)