chore: validate that logicalId is always a string (#1072)

sorccu · web-flow · commit 5a23fd003fa2 · 2025-05-20T20:53:54.000+09:00
diff --git a/packages/cli/src/constructs/project.ts b/packages/cli/src/constructs/project.ts
@@ -235,6 +235,10 @@ export class Session {
   }
 
   static validateCreateConstruct (construct: Construct) {
+    if (typeof construct.logicalId !== 'string') {
+      throw new ValidationError(`The "logicalId" of a construct must be a string (logicalId=${construct.logicalId} [${typeof construct.logicalId}])`)
+    }
+
     if (!/^[A-Za-z0-9_\-/#.]+$/.test(construct.logicalId)) {
       throw new ValidationError(`The "logicalId" can only include the following characters: [A-Za-z0-9_-/#.]. (logicalId='${construct.logicalId}')`)
     }

Original file line number	Diff line number	Diff line change
`@@ -235,6 +235,10 @@ export class Session {`
`235`	`235`	`}`
`236`	`236`
`237`	`237`	`static validateCreateConstruct (construct: Construct) {`
	`238`	`+ if (typeof construct.logicalId !== 'string') {`
	`239`	+ throw new ValidationError(`The "logicalId" of a construct must be a string (logicalId=${construct.logicalId} [${typeof construct.logicalId}])`)
	`240`	`+ }`
	`241`	`+`
`238`	`242`	`if (!/^[A-Za-z0-9_\-/#.]+$/.test(construct.logicalId)) {`
`239`	`243`	throw new ValidationError(`The "logicalId" can only include the following characters: [A-Za-z0-9_-/#.]. (logicalId='${construct.logicalId}')`)
`240`	`244`	`}`