feat(cli): auto-include pnpm patches directory in Playwright bundles#1273
Merged
feat(cli): auto-include pnpm patches directory in Playwright bundles#1273
Conversation
sorccu
previously approved these changes
Apr 6, 2026
thebiglabasky
approved these changes
Apr 6, 2026
When using pnpm, the CLI now automatically includes the `patches/` directory in Playwright check bundles if it exists, preventing `pnpm install` failures at runtime when patched dependencies are referenced in the lockfile. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…Includes The glob pattern harmlessly matches nothing when the directory doesn't exist, so the statSync check was redundant. This also removes the basePath parameter and simplifies the tests to pure logic checks. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
More precise than patches/** — only includes actual patch files, avoiding accidentally bundling unrelated files in the directory. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Prevents adding duplicate patches include when the user specifies the pattern with a relative prefix (./patches/**) or absolute path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
path.resolve ensures basePath is valid on Windows where /project is not treated as an absolute path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
sorccu
force-pushed
the
feat/auto-include-pnpm-patches
branch
from
224eba4 to
24d64d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
patches/*.patchin Playwright check bundles when using pnpm, preventingpnpm installfailures at runtime whenpatchedDependenciesare referenced in the lockfile./patches/**,patches/**, and absolute paths are all detected correctlyCloses SIM-208
Test plan
getAutoIncludes()— 13 tests all passingutil.spec.tstests still passcheck-parser.spec.tstests still pass (44/44)🤖 Generated with Claude Code