refactor(grpc): drop storeResponseBody from GrpcMonitor#1413
Merged
Conversation
gRPC checks always store the response body now — the backend removed the per-check "store response body" toggle and no longer accepts or returns the field. Remove it from the GrpcRequest construct type and the codegen emitter, and drop it from the affected fixtures. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013AYwkvoaANQTH5dGStbBj2
sorccu
force-pushed
the
grpc-remove-store-response-body
branch
from
July 17, 2026 18:06
83efb11 to
9fcfb16
Compare
sorccu
approved these changes
Jul 17, 2026
sorccu
enabled auto-merge (squash)
July 17, 2026 18:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes
storeResponseBodyfrom theGrpcMonitorrequest. gRPC checks always store the response body now — the backend removed the per-check "store response body" toggle and no longer accepts or returns the field, so exposing it in the construct is misleading.Changes
storeResponseBody?: booleanfrom theGrpcRequestconstruct type.grpc-request-codegen.ts), socheckly importno longer generates it.Notes
Minor breaking type change: a project that explicitly set
storeResponseBodyin aGrpcMonitorwill now get a TypeScript error. The field was already a no-op (the API ignores it), so removing it just surfaces that. No runtime behavior change — bodies are always stored.