fix(cli): add safe diagnostics for empty MQTT runner errors#1417
Open
timohuovinen wants to merge 1 commit into
Open
fix(cli): add safe diagnostics for empty MQTT runner errors#1417timohuovinen wants to merge 1 commit into
timohuovinen wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly Agent generated, needs a human verification.
Affected Components
Notes for the Reviewer
The check runner now reports actionable fallback diagnostics when MQTT connection or subscription errors have empty messages. Safe numeric and uppercase error codes are included when available, while unsafe values are omitted to avoid exposing sensitive data. Existing non-empty MQTT errors and typed scheduling errors are preserved.
Test plan
pnpm exec vitest --run ./src/services/__tests__/abstract-check-runner.spec.tsfrompackages/clipnpm exec eslint packages/cli/src/services/abstract-check-runner.ts packages/cli/src/services/__tests__/abstract-check-runner.spec.tspnpm --filter checkly prepare:distNew Dependency Submission
No new dependencies.