test(privateLocation): add privateLocation to test

Author: fluktuid

external/checkly/group_test.go

@@ -20,8 +20,9 @@ import "testing"
 
 func TestChecklyGroup(t *testing.T) {
 	data := Group{
-		Name:      "foo",
-		Locations: []string{"basement"},
+		Name:             "foo",
+		Locations:        []string{"basement"},
+		PrivateLocations: []string{"ground-floor"},
 	}
 
 	testData := checklyGroup(data)

internal/controller/checkly/group_controller_test.go

@@ -20,11 +20,12 @@ import (
 	"time"
 
 	"github.com/checkly/checkly-go-sdk"
-	checklyv1alpha1 "github.com/checkly/checkly-operator/api/checkly/v1alpha1"
 	. "github.com/onsi/ginkgo"
 	. "github.com/onsi/gomega"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/types"
+
+	checklyv1alpha1 "github.com/checkly/checkly-operator/api/checkly/v1alpha1"
 )
 
 var _ = Describe("ApiCheck Controller", func() {
@@ -51,6 +52,7 @@ var _ = Describe("ApiCheck Controller", func() {
 		It("Full reconciliation", func() {
 
 			updatedLocations := []string{"eu-west-2", "eu-west-1"}
+			updatedPrivateLocations := []string{"ground-floor"}
 			groupKey := types.NamespacedName{
 				Name: "test-group",
 			}
@@ -64,8 +66,9 @@ var _ = Describe("ApiCheck Controller", func() {
 					Name: groupKey.Name,
 				},
 				Spec: checklyv1alpha1.GroupSpec{
-					Locations:     []string{"eu-west-1"},
-					AlertChannels: []string{alertChannelKey.Name},
+					Locations:        []string{"eu-west-1"},
+					PrivateLocations: []string{},
+					AlertChannels:    []string{alertChannelKey.Name},
 				},
 			}
 
@@ -140,6 +143,20 @@ var _ = Describe("ApiCheck Controller", func() {
 				}
 			}, timeout, interval).Should(BeTrue())
 
+			updated.Spec.PrivateLocations = updatedPrivateLocations
+			Expect(k8sClient.Update(context.Background(), updated)).Should(Succeed())
+
+			By("Expecting update")
+			Eventually(func() bool {
+				f := &checklyv1alpha1.Group{}
+				err := k8sClient.Get(context.Background(), groupKey, f)
+				if len(f.Spec.PrivateLocations) == 1 && err == nil {
+					return true
+				} else {
+					return false
+				}
+			}, timeout, interval).Should(BeTrue())
+
 			// Delete group
 			By("Expecting to delete successfully")
 			Eventually(func() error {

internal/controller/checkly/suite_test.go

@@ -22,6 +22,7 @@ import (
 	"os"
 	"path/filepath"
 	"testing"
+	//+kubebuilder:scaffold:imports
 
 	"github.com/checkly/checkly-go-sdk"
 	. "github.com/onsi/ginkgo"
@@ -35,7 +36,6 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/log/zap"
 
 	checklyv1alpha1 "github.com/checkly/checkly-operator/api/checkly/v1alpha1"
-	//+kubebuilder:scaffold:imports
 )
 
 // These tests use Ginkgo (BDD-style Go testing framework). Refer to