Add Playwright check type comparison#80
Conversation
3044b5b to
a1ceb67
Compare
a1ceb67 to
9b83f86
Compare
There was a problem hiding this comment.
Pull Request Overview
Adds a new documentation page that compares Playwright-based monitoring options and links it into the docs navigation, with a shared snippet for check run durations.
- Introduces a Playwright monitoring comparison page with feature table and guidance.
- Adds a reusable MDX snippet for max check durations.
- Registers the new page in docs.json.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| snippets/check-comparison.mdx | Exports shared check duration constants for reuse across docs. |
| docs.json | Adds navigation entry for the new comparison page. |
| detect/synthetic-monitoring/playwright-monitoring-comparison.mdx | New doc page with comparison content, imports shared durations, and presents a feature table. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| | Supported test formats | API and Browser | API and Browser | API only | | ||
| | Multiple spec files | Yes | No | No | | ||
| | Flexible test selection via tags and projects | Yes | No | No | | ||
| | Browser compatibility | Chromium, Webkit, Firefox | Chromium, Chrome | Chromium, Chrome | |
There was a problem hiding this comment.
This row states that MultiStep Checks support 'Chromium, Chrome', but line 20 clarifies there's no browser available for MultiStep Checks. Update the MultiStep column to 'N/A' or 'None' to avoid contradiction.
| | Browser compatibility | Chromium, Webkit, Firefox | Chromium, Chrome | Chromium, Chrome | | |
| | Browser compatibility | Chromium, Webkit, Firefox | Chromium, Chrome | N/A | |
| | Feature | Playwright Check Suite | Browser Check | MultiStep Check | | ||
| |-----------------------------------------------|-------------------------------|---------------------------------|---------------------------------| |
There was a problem hiding this comment.
The table header and separator should not include a leading empty column. The current diff shows double leading pipes earlier; ensure you use a single leading pipe per row as shown here to prevent an extra empty column.
| | Supported test formats | API and Browser | API and Browser | API only | | ||
| | Multiple spec files | Yes | No | No | | ||
| | Flexible test selection via tags and projects | Yes | No | No | | ||
| | Browser compatibility | Chromium, Webkit, Firefox | Chromium, Chrome | Chromium, Chrome | |
There was a problem hiding this comment.
Capitalize 'WebKit' correctly.
| | Browser compatibility | Chromium, Webkit, Firefox | Chromium, Chrome | Chromium, Chrome | | |
| | Browser compatibility | Chromium, WebKit, Firefox | Chromium, Chrome | Chromium, Chrome | |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
MariadeAnton
left a comment
There was a problem hiding this comment.
Minor suggestions for clarity @stefanjudis !
| | Feature | Playwright Check Suites | Browser Check | MultiStep Check | | ||
| |-----------------------------------------------|-------------------------------|---------------------------------|---------------------------------| | ||
| | Supports *Monitoring as Code* | Yes | Yes | Yes | | ||
| | Supported test formats | API and Browser | API and Browser | API only | |
There was a problem hiding this comment.
| | Supported test formats | API and Browser | API and Browser | API only | | |
| | [Test fixtures ](https://playwright.dev/docs/test-fixtures) | API and Browser | API and Browser | API only | |
Would it make sense to make this Playwright named? As In Test Fixtures
There was a problem hiding this comment.
I like that a lot! 💯 But I'll go for the actual fixtures names instead of browser and api.
Co-authored-by: María de Antón <maria@checklyhq.com>
Co-authored-by: María de Antón <maria@checklyhq.com>
Co-authored-by: María de Antón <maria@checklyhq.com>
Co-authored-by: María de Antón <maria@checklyhq.com>
Co-authored-by: María de Antón <maria@checklyhq.com>
Co-authored-by: María de Antón <maria@checklyhq.com>
|
@MariadeAnton Ready for another round. I think it's way smoother and rounder now. :) great stuff! |
Co-authored-by: María de Antón <maria@checklyhq.com>
Affected Components
Notes for the Reviewer
As part of documenting the migration from MultiStep or Browser checks I formalized the different playwright capabilities of all check types. :)