Replace olekukonko/tablewriter with text/tabwriter#167
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
==========================================
+ Coverage 71.43% 72.01% +0.57%
==========================================
Files 13 13
Lines 1565 1597 +32
==========================================
+ Hits 1118 1150 +32
Misses 373 373
Partials 74 74 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e63963d to
a36cdbc
Compare
|
@rst0git @snprajwal This update was created with Claude. The main reason to create was that dependabot now combines all changes and the tablewriter change breaks API. That is why I wanted to do it in a separate PR. The new tablewriter comes with new features and new dependencies which increase the binary size. Not sure if this is too much. If I am able to correctly read the number it is 700KB larger than before. |
|
@adrianreber AI models sometimes generate code that is incorrect. It compiles and runs but does not do what we want. |
a36cdbc to
de26713
Compare
|
Let me also update README.md. |
de26713 to
a798d1a
Compare
|
Dropping tablewriter decreases binary size by 400K |
dcef214 to
a53dea9
Compare
|
@adrianreber Would it be possible to apply the following changes to your patch? This approach is similar to the one used in: |
a53dea9 to
e59c4c6
Compare
|
I told claude to update the PR with the changes @rst0git suggested. |
Drop external tablewriter dependency in favor of Go's built-in text/tabwriter package to reduce dependencies and simplify maintenance. Changes: - Replace tablewriter.NewWriter() with tabwriter.NewWriter() in all table display functions - Update table formatting logic to use tab-separated output with headers and separator lines - Remove olekukonko/tablewriter and related dependencies from go.mod - Update test expectations to match new table output format - Fix test line number references after table format changes All tests pass with the new implementation. Assisted-by: Claude AI for dependency replacement and test updates Signed-off-by: Adrian Reber <areber@redhat.com> Signed-off-by: Radostin Stoyanov <rstoyano@redhat.com>
e59c4c6 to
e7beaf5
Compare
It seems like Claude doesn't know that it also needs to update the README file. |
After some anonymous third party review, I completed changed the approach to this PR. Instead of using the external dependency tablewriter this now uses text/tabwriter. This reduces included code.
Drop external tablewriter dependency in favor of Go's built-in text/tabwriter package to reduce dependencies and simplify maintenance.
Changes:
All tests pass with the new implementation.
Assisted-by: Claude AI for dependency replacement and test updates