ci: install git in the Fedora container#214
Merged
Merged
Conversation
adrianreber
force-pushed
the
2026-04-19-git
branch
from
d18f41b to
d437929
Compare
Especially as codecov seems to require it now. Signed-off-by: Adrian Reber <areber@redhat.com>
adrianreber
force-pushed
the
2026-04-19-git
branch
from
d437929 to
5754c41
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
=======================================
Coverage 79.98% 79.98%
=======================================
Files 16 16
Lines 1759 1759
=======================================
Hits 1407 1407
Misses 263 263
Partials 89 89 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rst0git
reviewed
Apr 20, 2026
| run: | | ||
| dnf install -y bats iptables iproute jq criu golang make git | ||
| - name: Fix git safe directory | ||
| run: git config --global --add safe.directory /__w/checkpointctl/checkpointctl |
Member
There was a problem hiding this comment.
Would it work if we use "$GITHUB_WORKSPACE" here (actions/checkout#2031 (comment))?
Member
Author
There was a problem hiding this comment.
Yes, I was using that also, but I wanted to include this also in the premade containers in the other script and that would probably not work there. I can still change it. This is more a quick fix to make sure CI works again here. Let me know if you prefer to have the variable here (even if it is changed with the container setup).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Especially as codecov seems to require it now.