Skip to content

ci: install git in the Fedora container #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rst0git merged 1 commit into from
Apr 20, 2026
+5 −3
Merged

ci: install git in the Fedora container #214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,16 @@ jobs:
image: fedora:latest
options: --privileged
steps:
- name: Install tools
run: |
dnf install -y bats iptables iproute jq criu golang make git
- name: Fix git safe directory
run: git config --global --add safe.directory /__w/checkpointctl/checkpointctl
Copy link
Copy Markdown
Member

@rst0git rst0git Apr 20, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it work if we use "$GITHUB_WORKSPACE" here (actions/checkout#2031 (comment))?

Copy link
Copy Markdown
Member Author

@adrianreber adrianreber Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I was using that also, but I wanted to include this also in the premade containers in the other script and that would probably not work there. I can still change it. This is more a quick fix to make sure CI works again here. Let me know if you prefer to have the variable here (even if it is changed with the container setup).

- name: checkout
uses: actions/checkout@v4
with:
# needed for codecov
fetch-depth: 0
- name: Install tools
run: |
dnf install -y bats iptables iproute jq criu golang make
- name: Run make coverage
run: make coverage

Expand Down
Loading