Issue #451: add AnonInnerLength to checkstyle config

Author: Calixte

config/checkstyle-checks.xml

@@ -750,7 +750,8 @@
             <property name="ignoreComments" value="true"/>
         </module>
 
-    <!-- Size Violations -->
+        <!-- Size Violations -->
+        <module name="AnonInnerLength"/>
         <module name="LambdaBodyLength"/>
         <module name="MethodCount">
             <property name="maxTotal" value="34"/>

net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationReader.java

@@ -155,32 +155,19 @@ private static List<Module> getModules(final Document document) {
     final List<Module> modules = new ArrayList<>();
 
     document.accept(new VisitorSupport() {
-
       @Override
       public void visit(final Element node) {
-
         if (XMLTags.MODULE_TAG.equals(node.getName())) {
-
           final String name = node.attributeValue(XMLTags.NAME_TAG);
-
           final RuleMetadata metadata = MetadataFactory.getRuleMetadata(name);
-          Module module = null;
-          if (metadata != null) {
-            module = new Module(metadata, true);
-          } else {
-            module = new Module(name);
-          }
-
+          Module module = metadata != null ? new Module(metadata, true) : new Module(name);
           addProperties(node, module);
           addMessages(node, module);
           addMetadata(node, module);
-
-          // if the module has not metadata attached we create some
-          // generic metadata
+          // if the module has not metadata attached we create some generic metadata
           if (module.getMetaData() == null) {
             MetadataFactory.createGenericMetadata(module);
           }
-
           modules.add(module);
         }
       }

net.sf.eclipsecs.sample/src/net/sf/eclipsecs/sample/checks/MethodLimitQuickfix.java

@@ -41,7 +41,6 @@ protected ASTVisitor handleGetCorrectingASTVisitor(final IRegion lineInfo,
       @Override
       @SuppressWarnings("unchecked")
       public boolean visit(MethodDeclaration node) {
-
         Javadoc doc = node.getJavadoc();
 
         if (doc == null) {

net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/ApplicationStartedHandler.java

@@ -20,26 +20,24 @@
 
 package net.sf.eclipsecs.ui;
 
-import org.osgi.service.component.annotations.Component;
-import org.osgi.service.event.EventConstants;
-import org.osgi.service.event.EventHandler;
-
-import net.sf.eclipsecs.core.jobs.AbstractCheckJob;
-import net.sf.eclipsecs.ui.properties.filter.CheckFileOnOpenPartListener;
-
-import java.util.Collection;
-import java.util.Collections;
-import java.util.HashSet;
+import java.util.Arrays;
+import java.util.Set;
+import java.util.stream.Collectors;
 
 import org.eclipse.e4.ui.workbench.UIEvents;
-import org.eclipse.ui.IEditorReference;
 import org.eclipse.ui.IWindowListener;
 import org.eclipse.ui.IWorkbench;
 import org.eclipse.ui.IWorkbenchPage;
 import org.eclipse.ui.IWorkbenchPartReference;
 import org.eclipse.ui.IWorkbenchWindow;
 import org.eclipse.ui.PlatformUI;
 import org.eclipse.ui.progress.IProgressService;
+import org.osgi.service.component.annotations.Component;
+import org.osgi.service.event.EventConstants;
+import org.osgi.service.event.EventHandler;
+
+import net.sf.eclipsecs.core.jobs.AbstractCheckJob;
+import net.sf.eclipsecs.ui.properties.filter.CheckFileOnOpenPartListener;
 
 /**
  * Event handler being called when the eclipse application has started.
@@ -50,7 +48,6 @@ public final class ApplicationStartedHandler implements EventHandler {
   private final CheckFileOnOpenPartListener mPartListener = new CheckFileOnOpenPartListener();
 
   private final IWindowListener mWindowListener = new IWindowListener() {
-
     @Override
     public void windowOpened(IWorkbenchWindow window) {
       window.getPartService().addPartListener(mPartListener);
@@ -63,13 +60,11 @@ public void windowActivated(IWorkbenchWindow window) {
     @Override
     public void windowClosed(IWorkbenchWindow window) {
       window.getPartService().removePartListener(mPartListener);
-
     }
 
     @Override
     public void windowDeactivated(IWorkbenchWindow window) {
     }
-
   };
 
   @Override
@@ -87,35 +82,20 @@ private void registerListener() {
     workbench.getDisplay().asyncExec(new Runnable() {
       @Override
       public void run() {
-
-        IWorkbenchWindow[] windows = workbench.getWorkbenchWindows();
-
-        for (IWorkbenchWindow window : windows) {
-
+        for (IWorkbenchWindow window : workbench.getWorkbenchWindows()) {
           if (window != null) {
-
-            // collect open editors and have then run against Checkstyle if
-            // appropriate
-            Collection<IWorkbenchPartReference> parts = new HashSet<>();
-
-            // add already opened files to the filter
-            // bugfix for 2923044
-            IWorkbenchPage[] pages = window.getPages();
-            for (IWorkbenchPage page : pages) {
-
-              IEditorReference[] editorRefs = page.getEditorReferences();
-              Collections.addAll(parts, editorRefs);
-            }
-
+            // collect open editors and have then run against Checkstyle if appropriate
+            // add already opened files to the filter - bugfix for 2923044
+            Set<IWorkbenchPartReference> parts = Arrays.stream(window.getPages())
+                .map(IWorkbenchPage::getEditorReferences)
+                .flatMap(Arrays::stream)
+                .collect(Collectors.toSet());
             mPartListener.partsOpened(parts);
-
-            // remove listener first for safety, we don't want
-            // register the same listener twice accidently
+            // remove listener first for safety, we don't want to register the same listener twice accidently
             window.getPartService().removePartListener(mPartListener);
             window.getPartService().addPartListener(mPartListener);
           }
         }
-
         workbench.addWindowListener(mWindowListener);
       }
     });

net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/CheckConfigurationPropertiesDialog.java

@@ -25,7 +25,6 @@
 import org.eclipse.jface.viewers.ArrayContentProvider;
 import org.eclipse.jface.viewers.ComboViewer;
 import org.eclipse.jface.viewers.ISelectionChangedListener;
-import org.eclipse.jface.viewers.IStructuredSelection;
 import org.eclipse.jface.viewers.LabelProvider;
 import org.eclipse.jface.viewers.SelectionChangedEvent;
 import org.eclipse.jface.viewers.StructuredSelection;
@@ -192,26 +191,19 @@ protected Control createDialogArea(Composite parent) {
     mConfigType.addSelectionChangedListener(new ISelectionChangedListener() {
       @Override
       public void selectionChanged(SelectionChangedEvent event) {
-        if (event.getSelection() instanceof IStructuredSelection) {
-          IConfigurationType type = (IConfigurationType) ((IStructuredSelection) event
-                  .getSelection()).getFirstElement();
-
-          if (mConfigType.getCombo().isEnabled()) {
-
-            String oldName = mCheckConfig.getName();
-            String oldDescr = mCheckConfig.getDescription();
-
-            mCheckConfig = mWorkingSet.newWorkingCopy(type);
-            try {
-              mCheckConfig.setName(oldName);
-            } catch (CheckstylePluginException ex) {
-              // NOOP
-            }
-            mCheckConfig.setDescription(oldDescr);
+        IConfigurationType type = (IConfigurationType) event.getStructuredSelection().getFirstElement();
+        if (mConfigType.getCombo().isEnabled()) {
+          String oldName = mCheckConfig.getName();
+          String oldDescr = mCheckConfig.getDescription();
+          mCheckConfig = mWorkingSet.newWorkingCopy(type);
+          try {
+            mCheckConfig.setName(oldName);
+          } catch (CheckstylePluginException ex) {
+            // NOOP
           }
-
-          createConfigurationEditor(mCheckConfig);
+          mCheckConfig.setDescription(oldDescr);
         }
+        createConfigurationEditor(mCheckConfig);
       }
     });
 

net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/blocks/AvoidNestedBlocksQuickfix.java

@@ -44,26 +44,18 @@ protected ASTVisitor handleGetCorrectingASTVisitor(final IRegion lineInfo,
           final int markerStartOffset) {
 
     return new ASTVisitor() {
-
       @SuppressWarnings("unchecked")
       @Override
       public boolean visit(Block node) {
-
         if (containsPosition(lineInfo, node.getStartPosition())) {
-
           if (node.getParent() instanceof Block) {
-
             List<?> statements = ((Block) node.getParent()).statements();
             int index = statements.indexOf(node);
-
             statements.remove(node);
             statements.addAll(index, ASTNode.copySubtrees(node.getAST(), node.statements()));
-
           } else if (node.getParent() instanceof SwitchStatement) {
-
             List<?> statements = ((SwitchStatement) node.getParent()).statements();
             int index = statements.indexOf(node);
-
             statements.remove(node);
             statements.addAll(index, ASTNode.copySubtrees(node.getAST(), node.statements()));
           }