Issue #451: add LineLength to checkstyle config

Author: Calixte

config/checkstyle-checks.xml

@@ -250,6 +250,12 @@
     <module name="FileLength">
         <property name="fileExtensions" value="java"/>
     </module>
+    <module name="LineLength">
+        <property name="fileExtensions" value="java"/>
+        <property name="max" value="100"/>
+        <property name="ignorePattern"
+                  value="^( *\* *([^ ]+|\{@code .*|&lt;a href=&quot;[^&quot;]+&quot;&gt;)|(package|import) .*)$"/>
+    </module>
 
     <!-- Whitespace -->
     <module name="FileTabCharacter">

net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/CheckstylePlugin.java

@@ -43,7 +43,7 @@ public class CheckstylePlugin extends Plugin {
   public static final String PLUGIN_ID = "net.sf.eclipsecs.core"; //$NON-NLS-1$
 
   /** Extension point id for Checkstyle addon providers. */
-  private static final String ADDON_PROVIDER_EXT_PT_ID = PLUGIN_ID + ".checkstyleAddonProvider"; //$NON-NLS-1$
+  private static final String ADDON_PROVIDER_EXT_PT_ID = PLUGIN_ID + ".checkstyleAddonProvider";
 
   /**
    *  Platform Locale.
@@ -70,7 +70,7 @@ public void start(BundleContext context) throws Exception {
             ADDON_PROVIDER_EXT_PT_ID);
 
     try {
-      Logger checkstyleErrorLog = Logger.getLogger("com.puppycrawl.tools.checkstyle.ExceptionLog"); //$NON-NLS-1$
+      Logger checkstyleErrorLog = Logger.getLogger("com.puppycrawl.tools.checkstyle.ExceptionLog");
 
       checkstyleErrorLog.addHandler(new EclipseLogHandler(this));
       checkstyleErrorLog.setLevel(Level.ALL);

net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/CheckstylePluginPrefs.java

@@ -50,7 +50,7 @@ public class CheckstylePluginPrefs extends AbstractPreferenceInitializer {
    * Preference name indicating if the number of checkstyle warning generated per file should be
    * limited.
    */
-  public static final String PREF_LIMIT_MARKERS_PER_RESOURCE = "limit.markers.per.resource"; //$NON-NLS-1$
+  public static final String PREF_LIMIT_MARKERS_PER_RESOURCE = "limit.markers.per.resource";
 
   /**
    * Preference name for the preference that stores the limit of markers per resource.

net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/builder/CheckstyleBuilder.java

@@ -65,7 +65,7 @@
 public class CheckstyleBuilder extends IncrementalProjectBuilder {
 
   /** Eclipse extension point ID for the builder. */
-  public static final String BUILDER_ID = CheckstylePlugin.PLUGIN_ID + ".CheckstyleBuilder"; //$NON-NLS-1$
+  public static final String BUILDER_ID = CheckstylePlugin.PLUGIN_ID + ".CheckstyleBuilder";
 
   /**
    * Run the Checkstyle builder on all open projects in the workspace.
@@ -305,8 +305,8 @@ private <T extends IResource> Map<CheckConfiguration, Auditor> resolveAudits(
    * @throws CoreException
    *           an unexpected error occurred
    */
-  private Collection<IResource> getResources(final IResourceDelta delta, final List<AuditFilter> filters)
-          throws CoreException {
+  private Collection<IResource> getResources(final IResourceDelta delta,
+          final List<AuditFilter> filters) throws CoreException {
 
     List<IResource> resources = new ArrayList<>();
 
@@ -356,8 +356,8 @@ private Collection<IResource> getResources(final IResourceDelta delta, final Lis
    * @throws CoreException
    *           an unexpected error occurred
    */
-  private Collection<IResource> getResources(final IContainer container, final List<AuditFilter> filters)
-          throws CoreException {
+  private Collection<IResource> getResources(final IContainer container,
+          final List<AuditFilter> filters) throws CoreException {
 
     List<IResource> resources = new ArrayList<>();
 

net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/builder/CheckstyleMarker.java

@@ -30,7 +30,7 @@
  */
 public final class CheckstyleMarker {
   /** ID for the CheckstyleMarker. */
-  public static final String MARKER_ID = CheckstylePlugin.PLUGIN_ID + ".CheckstyleMarker"; //$NON-NLS-1$
+  public static final String MARKER_ID = CheckstylePlugin.PLUGIN_ID + ".CheckstyleMarker";
 
   /** Module name key in marker attributes. */
   public static final String MODULE_NAME = "ModuleName"; //$NON-NLS-1$

net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfigurationTester.java

@@ -56,8 +56,8 @@ private CheckConfigurationTester() {
    * @throws CheckstylePluginException
    *           most likely the configuration file could not be found
    */
-  public static List<ResolvableProperty> getUnresolvedProperties(CheckConfiguration checkConfiguration)
-          throws CheckstylePluginException {
+  public static List<ResolvableProperty> getUnresolvedProperties(
+          CheckConfiguration checkConfiguration) throws CheckstylePluginException {
 
     CheckstyleConfigurationFile configFile = checkConfiguration.getCheckstyleConfiguration();
 

net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfigurationWorkingCopy.java

@@ -114,7 +114,8 @@ public CheckConfigurationWorkingCopy(ConfigurationType configType,
           CheckConfigurationWorkingSet workingSet, boolean global) {
 
     mWorkingSet = workingSet;
-    mCheckConfiguration = new DefaultCheckConfiguration(null, null, null, configType, global, null, null);
+    mCheckConfiguration = new DefaultCheckConfiguration(null, null, null, configType, global, null,
+            null);
   }
 
   /**

net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationReader.java

@@ -123,8 +123,8 @@ private ConfigurationReader() {
   }
 
   /**
-   * Reads the checkstyle configuration from the given stream and returns a list of all modules within
-   * this configuration.
+   * Reads the checkstyle configuration from the given stream and returns a list of all modules
+   * within this configuration.
    *
    * @param input
    *          the stream the configuration is loaded from

net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationWriter.java

@@ -92,9 +92,8 @@ public static void write(OutputStream out, List<Module> modules, CheckConfigurat
 
       String lineSeperator = System.lineSeparator();
 
-      String comment = lineSeperator
-              + "    This configuration file was written by the eclipse-cs plugin configuration editor" //$NON-NLS-1$
-              + lineSeperator;
+      String comment = lineSeperator + "    This configuration file was written by "
+              + "the eclipse-cs plugin configuration editor" + lineSeperator;
       doc.addComment(comment);
 
       // write out name and description as comment
@@ -231,12 +230,11 @@ private static Element writeModule(Module module, Branch parent) {
    * @return the list of child modules
    */
   private static List<Module> getChildModules(Module module, List<Module> remainingModules) {
-
     List<Module> childModules = new ArrayList<>();
 
     for (Module tmp : remainingModules) {
-
-      String parentInternalName = module != null ? module.getMetaData().identity().internalName() : null;
+      String parentInternalName = module != null ? module.getMetaData().identity().internalName()
+              : null;
       String childParent = tmp.getMetaData().identity().parent();
 
       // only the checker module has no parent

net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/DefaultCheckConfiguration.java

@@ -83,8 +83,8 @@ public class DefaultCheckConfiguration extends AbstractCheckConfiguration {
    * @param additionalData
    *          a map of additional data for this configuration
    */
-  public DefaultCheckConfiguration(final String name, final String location, final String description,
-          final ConfigurationType type, final boolean global,
+  public DefaultCheckConfiguration(final String name, final String location,
+          final String description, final ConfigurationType type, final boolean global,
           final List<ResolvableProperty> properties, final Map<String, String> additionalData) {
     mName = name;
     mLocation = location;