📈 🎉 Pub joint temps#1
Merged
Merged
Conversation
luisrayas3
approved these changes
Oct 5, 2022
luisrayas3
left a comment
There was a problem hiding this comment.
I think the main bit of testing I kinda want to see, but think we can skip for this PR, is checking the effect on the loop timing. Hopefully we don't do too much patching but if we do we may need to invest a bit of time on validating this
Collaborator
Author
Good point about the loop timing and agree that we should monitor this going forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add joint temperature publishing capabilities to the
ur_hardware_interfacenode.Includes a new package --
ur_rtde_msgs-- for the joint temperatures message definition. Can move this intoChefAutonomyinstead, but leaving in this repo for now.Based off of these:
Testing:
ur_hardware_interface/joint_temperatures