fix: reduce macOS idle CPU when window is hidden#2202
Open
Code-newWorld wants to merge 1 commit into
Open
Conversation
Follow-up to tray-title dedup (chen08209#2201 / chen08209#1644): - Expose Render.isPaused and skip per-second runtime/traffic IPC while the window is hidden and the tray title is off - Skip TUN request-event JSON parsing while the window is hidden - Silence getTraffic/getTotalTraffic invoke logs that flood every second Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #2201 (tray-title dedup). Remaining idle-CPU reductions when the window is hidden:
updateRunTime/updateTrafficcore IPC whileRender.isPausedandshowTrayTitleis offrequestpush events while the window is hiddengetTraffic/getTotalTrafficinvokeThese are independent of the tray
setTitlefix in #2201 / #1644.Test plan
Supersedes the non-tray parts of #2186.