feat(apk): add support for adaptive icon parsing#92
Open
Klowner wants to merge 2 commits into
Open
Conversation
Owner
|
@Klowner I haven't reviewed the code yet, but have a comment about the output. The icon's type is changed from string to object, that brings a break-change to this library. Maybe store the adaptive icon output to a new key like |
…reuse icon property
Author
|
Thank you for the feedback, @chenquincy. I've changed it so the adaptive icons are exposed via Here's an example apk containing adaptive icon specification (this example only contains a "foreground" image). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds support for Android adaptive icons as discussed in #91.
If
application.iconis an XML resource, it is assumed to be an adaptive icon file. The individual components are parsed from it and assigned toapkInfoin the format:If any of foreground, background, or monochrome are not present in the XML or cannot be mapped to valid resources, those keys are omitted from the result object.
Please feel free to request any modifications!
Thank you!
-Mark