Skip to content

Fix OrientationIndependentConstraints to reject infinity size #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cheonjaeung merged 1 commit into from
May 10, 2026
Merged

Fix OrientationIndependentConstraints to reject infinity size #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions grid/src/commonMain/kotlin/com/cheonjaeung/compose/grid/OrientationIndependentConstraints.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ import kotlin.jvm.JvmInline

private const val Infinity = 0xFFFF

private const val MaxSize = Infinity

private const val MainAxisMinSizeBitOffset = 48
private const val MainAxisMaxSizeBitOffset = 32
private const val CrossAxisMinSizeBitOffset = 16
Expand Down Expand Up @@ -66,8 +64,8 @@ private fun packOrientationIndependentConstraints(
"minSize must be less than or equal to maxSize"
}

require(mainAxisMaxSizeValue <= MaxSize && crossAxisMaxSizeValue <= MaxSize) {
"size must be less than $MaxSize"
require(mainAxisMaxSizeValue < Infinity && crossAxisMaxSizeValue < Infinity) {
"size must be less than $Infinity"
}

// Pack 4 integer sizes into 64 bits.
Expand Down Expand Up @@ -99,7 +97,7 @@ private fun packOrientationIndependentConstraints(
* If the constraints instance is created frequently, it can cause GC pressure and laggy frame.
* For inlining this constraints representation, this class uses a single [Long] to pack and
* represent the four integer sizes: [mainAxisMinSize], [mainAxisMaxSize], [crossAxisMinSize], and
* [crossAxisMaxSize]. Each size is allocated 16 bits, allowing a maximum value of 65534 (2^16 - 1)
* [crossAxisMaxSize]. Each size is allocated 16 bits, allowing a maximum value of 65534
* for each individual constraint component. 65535 is used to represent infinity.
*/
@Immutable
Expand Down