fix: Optimise sleep and wait functions in upgrade tests [DEV-5514] & Optimise sleep funtions in fee abs tests [DEV-5515]#942
Merged
Conversation
Contributor
|
Task linked: DEV-5514 Optimise sleep and wait functions in upgrade tests |
Eengineer1
added a commit
that referenced
this pull request
Dec 4, 2025
* docs: Add v4-minor testnet upgrade binaries file (#936) * docs: Add v4-minor upgrade binaries file * Switch to v4.1.6 instead of beta release * docs: Add mainnet v4-minor upgrade binaries file (#940) * docs: Add v4-minor upgrade binaries file * Switch to v4.1.6 instead of beta release * Add mainnet v4-minor binaries * fix: Optimise sleep and wait functions in upgrade tests [DEV-5514] & Optimise sleep funtions in fee abs tests [DEV-5515] (#942) * optimized sleep and wait functions in tests * revert wait time * split docker tag approach * split docker tag approach * switch to tag based approach * fixed readable events slice * fix panic due to negative tax amount * Added failsafe assertion adjustment * Increase decrement to counter jitter --------- Co-authored-by: Filip Djokic <87134019+filipdjokic@users.noreply.github.com> Co-authored-by: Tasos Derisiotis <50984242+Eengineer1@users.noreply.github.com> Co-authored-by: Tasos Derisiotis <tasosderiziotis@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimizes
sleepandWaitForChainHeightfunctions present in the upgrade and feeabs tests.Note: During testing on a forked repo it was discovered that the docker localnet does not have a consistent behavior while creating and committing new blocks. Average block time ranged from 500ms to 2s across different CI runs. Due to this inconsistency the tests require a certain level of buffer time. Further reduction of
sleepandWaitForChainHeightfunctions will lead to failed CI tests even if those pass locally.