fix: Resolve ESLint issues to improve code quality [DEV-4792] (#274)

* fix: Resolve ESLint issues to improve code quality

First set of fixes are the automatic fixes suggested on `npm run lint:fix`

* Ditch unused getRandomGroup

* Remove `request` parameter where not required

This helps resolve "'request' is defined but never used" linting errors.

* Remove error for unused variables for `ctx` and `controller`

Need to retain the parameters for structure but suppress linting error.

* Remove redundant `insertResult`

We can invoke the DB insert directly, since the value of `insertResult` is never used

* Better error catching in circulating supplyz

* Update worker-types.d.ts

Worker Types: Changing Promise<any> to Promise<unknown> maintains compatibility while being more type-safe. The unknown type can hold any value just like any, but requires type checking before use, which is actually safer.

* Update node.ts

Node Types: The ValidatorRewards type directly models the existing data structure based on how it's used.

* Replace `any` with AnalyticsItem

* Fix export path type issues

* Fix error in db any usage

* Remove ExportAnalyticsItem

This was breaking the structure of CSV response

* Fix type issues in GraphQL

* Restore original CSV format

* Make export for CSV's consistent

* Revert combining

* Strong types

---------

Co-authored-by: filipdjokic <djokicf@protonmail.com>

Author: ankurdotb

src/api/bigDipperApi.ts

@@ -16,21 +16,21 @@ export class BigDipperApi {
 	constructor(public readonly graphql_client: GraphQLClient) {}
 
 	async getTotalSupply(): Promise<number> {
-		let query = `query TotalSupply {
+		const query = `query TotalSupply {
       supply {
         coins
       }
     }`;
 
-		let resp = await this.graphql_client.query<{
+		const resp = await this.graphql_client.query<{
 			data: TotalSupplyResponse;
 		}>(query);
 
 		return Number(resp.data.supply[0].coins.find((coin) => coin.denom === 'ncheq')?.amount || '0');
 	}
 
 	getTotalStakedCoins = async (): Promise<string> => {
-		let query = `query StakingInfo{
+		const query = `query StakingInfo{
             staking_pool {
                 bonded_tokens
             }

src/api/nodeApi.ts

@@ -4,22 +4,22 @@ export class NodeApi {
 	constructor(public readonly base_rest_api_url: string) {}
 
 	async getAccountInfo(address: string): Promise<Account> {
-		let resp = await fetch(`${this.base_rest_api_url}/cosmos/auth/v1beta1/accounts/${address}`);
-		let respJson = (await resp.json()) as { account: Account };
+		const resp = await fetch(`${this.base_rest_api_url}/cosmos/auth/v1beta1/accounts/${address}`);
+		const respJson = (await resp.json()) as { account: Account };
 
 		return respJson.account;
 	}
 
 	async getAvailableBalance(address: string): Promise<Coin[]> {
-		let resp = await fetch(`${this.base_rest_api_url}/cosmos/bank/v1beta1/balances/${address}`);
-		let respJson = (await resp.json()) as { balances: Coin[] };
+		const resp = await fetch(`${this.base_rest_api_url}/cosmos/bank/v1beta1/balances/${address}`);
+		const respJson = (await resp.json()) as { balances: Coin[] };
 
 		return respJson.balances;
 	}
 
 	async distributionGetRewards(address: string): Promise<number> {
-		let resp = await fetch(`${this.base_rest_api_url}/cosmos/distribution/v1beta1/delegators/${address}/rewards`);
-		let respJson = (await resp.json()) as RewardsResponse;
+		const resp = await fetch(`${this.base_rest_api_url}/cosmos/distribution/v1beta1/delegators/${address}/rewards`);
+		const respJson = (await resp.json()) as RewardsResponse;
 
 		return Number(respJson?.total?.[0]?.amount ?? '0');
 	}

src/database/scripts/initialDataFetch.ts

@@ -14,7 +14,7 @@ clientConfig.ssl = {
 	ca: fs.readFileSync('/tmp/do-cert.pem').toString(),
 };
 
-let client = new Client(clientConfig);
+const client = new Client(clientConfig);
 
 client.connect();
 const db = drizzle(client, { logger: false });

src/database/scripts/seed.ts

@@ -12,7 +12,7 @@ clientConfig.ssl = {
 	ca: fs.readFileSync('/tmp/do-cert.pem').toString(),
 };
 
-let client = new Client(clientConfig);
+const client = new Client(clientConfig);
 
 client.connect();
 const db = drizzle(client, { logger: true });

src/handlers/analytics.ts

@@ -146,7 +146,7 @@ function parseQueryParams(url: URL): AnalyticsQueryParams {
 export async function handler(
 	request: IRequest,
 	env: Env,
-	ctx: ExecutionContext,
+	_ctx: ExecutionContext,
 	network: Network,
 	entityType?: EntityType
 ): Promise<Response> {

src/handlers/circulatingSupply.ts

@@ -1,7 +1,6 @@
-import { IRequest } from 'itty-router';
 import { getCirculatingSupply } from '../helpers/circulating';
 
-export async function handler(request: IRequest, env: Env): Promise<Response> {
+export async function handler(env: Env): Promise<Response> {
 	try {
 		const circulating_supply = await getCirculatingSupply(env);
 		return new Response(circulating_supply.toString());

src/handlers/liquidBalance.ts

@@ -11,34 +11,34 @@ export async function handler(request: IRequest, env: Env): Promise<Response> {
 		throw new Error('No address specified or wrong address format.');
 	}
 
-	let api = new NodeApi(env.REST_API);
+	const api = new NodeApi(env.REST_API);
 	const account = await api.getAccountInfo(address);
 
 	if (!isVestingAccount(account['@type'])) {
 		throw new Error(`Only vesting accounts are supported. Accounts type '${account['@type']}'.`);
 	}
 
 	if (isDelayedVestingAccount(account?.['@type'])) {
-		let balance =
+		const balance =
 			account?.base_vesting_account?.base_account?.sequence !== '0'
 				? Number(
 						(await (await api.getAvailableBalance(address)).find((b) => b.denom === 'ncheq')?.amount) ?? '0'
 					)
 				: 0;
-		let rewards = Number((await await api.distributionGetRewards(address)) ?? '0');
-		let delegated = Number(
+		const rewards = Number((await await api.distributionGetRewards(address)) ?? '0');
+		const delegated = Number(
 			account?.base_vesting_account?.delegated_free?.find((d) => d.denom === 'ncheq')?.amount ?? '0'
 		);
 
 		return new Response(convertToMainTokenDenom(balance + rewards + delegated, env.TOKEN_EXPONENT));
 	}
 
-	let vested_coins = Number(calculateVesting(account)?.vested);
-	let balance = Number(
+	const vested_coins = Number(calculateVesting(account)?.vested);
+	const balance = Number(
 		(await (await api.getAvailableBalance(address)).find((b) => b.denom === 'ncheq')?.amount) ?? '0'
 	);
-	let rewards = Number((await api.distributionGetRewards(address)) ?? '0');
-	let liquid_coins = vested_coins + balance + rewards;
+	const rewards = Number((await api.distributionGetRewards(address)) ?? '0');
+	const liquid_coins = vested_coins + balance + rewards;
 
 	return new Response(convertToMainTokenDenom(liquid_coins, env.TOKEN_EXPONENT));
 }

src/handlers/totalBalance.ts

@@ -3,6 +3,6 @@ import { fetchAccountBalances } from '../helpers/balance';
 
 export async function handler(request: IRequest, env: Env): Promise<Response> {
 	const address = request.params?.['address'];
-	let account_balance_infos = await fetchAccountBalances(address!!, env);
+	const account_balance_infos = await fetchAccountBalances(address!, env);
 	return new Response(account_balance_infos?.totalBalance.toString());
 }

src/handlers/totalStakedCoins.ts

@@ -1,13 +1,12 @@
-import { IRequest } from 'itty-router';
 import { BigDipperApi } from '../api/bigDipperApi';
 import { convertToMainTokenDenom } from '../helpers/currency';
 import { GraphQLClient } from '../helpers/graphql';
 
-export async function handler(request: IRequest, env: Env): Promise<Response> {
-	let gql_client = new GraphQLClient(env.GRAPHQL_API);
-	let bd_api = new BigDipperApi(gql_client);
+export async function handler(env: Env): Promise<Response> {
+	const gql_client = new GraphQLClient(env.GRAPHQL_API);
+	const bd_api = new BigDipperApi(gql_client);
 
-	let total_staked_coins = await bd_api.getTotalStakedCoins();
+	const total_staked_coins = await bd_api.getTotalStakedCoins();
 
 	return new Response(convertToMainTokenDenom(Number(total_staked_coins), env.TOKEN_EXPONENT));
 }

src/handlers/totalSupply.ts

@@ -1,11 +1,10 @@
-import { IRequest } from 'itty-router';
 import { BigDipperApi } from '../api/bigDipperApi';
 import { convertToMainTokenDenom } from '../helpers/currency';
 import { GraphQLClient } from '../helpers/graphql';
 
-export async function handler(request: IRequest, env: Env): Promise<Response> {
-	let gql_client = new GraphQLClient(env.GRAPHQL_API);
-	let bd_api = new BigDipperApi(gql_client);
+export async function handler(env: Env): Promise<Response> {
+	const gql_client = new GraphQLClient(env.GRAPHQL_API);
+	const bd_api = new BigDipperApi(gql_client);
 	const total_supply = await bd_api.getTotalSupply();
 	return new Response(convertToMainTokenDenom(total_supply, env.TOKEN_EXPONENT));
 }